Page MenuHomePhabricator
Differential D6307

[lib] modify reaction message generatesNotifs function to return a pushType based on the reaction action
ClosedPublic
Actions

Authored by ginsu on Jan 18 2023, 7:35 PM.
Tags
None
Referenced Files
F3494886: D6307.diff
Thu, Dec 19, 7:03 AM
Unknown Object (File)
Sat, Dec 14, 1:37 PM
Unknown Object (File)
Fri, Nov 22, 1:22 AM
Unknown Object (File)
Fri, Nov 22, 1:22 AM
Unknown Object (File)
Fri, Nov 22, 1:22 AM
Unknown Object (File)
Fri, Nov 22, 1:21 AM
Unknown Object (File)
Fri, Nov 22, 1:14 AM
Unknown Object (File)
Nov 4 2024, 2:16 AM
View All 88 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
tomek
Commits
rCOMM1f10bbfc7149: [lib] modify reaction message generatesNotifs function to return a pushType…
Summary

Modified generatesNotifs in reaction-message-spec to return notif if the reaction action is equal to add_reaction and rescind if the reaction action is equal to remove_reaction

Won't land this diff until the entire stack for this task is accepted and ready to land. The current changes would cause notifs to no longer send if a user were to unlike a message

Linear Task: ENG-2644

Test Plan

This will be further tested in subsequent diffs

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jan 18 2023, 7:35 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 18 2023, 7:35 PM
ginsu edited the summary of this revision. (Show Details)Jan 18 2023, 7:38 PM
ginsu added reviewers: atul, tomek.
Harbormaster completed remote builds in B15448: Diff 21060.Jan 18 2023, 7:49 PM
ginsu requested review of this revision.Jan 18 2023, 7:49 PM
tomek accepted this revision.Jan 19 2023, 3:40 AM
This revision is now accepted and ready to land.Jan 19 2023, 3:40 AM
ginsu added a child revision: D6829: [keyserver] convert existing logic for building userPushInfoPromises to an async function called generateNotifUserInfoPromise.Feb 21 2023, 10:49 PM
ginsu updated this revision to Diff 23102.Feb 26 2023, 11:09 AM

rebase before landing

Harbormaster completed remote builds in B16911: Diff 23102.Feb 26 2023, 11:25 AM
Closed by commit rCOMM1f10bbfc7149: [lib] modify reaction message generatesNotifs function to return a pushType… (authored by ginsu). · Explain WhyFeb 26 2023, 1:06 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM1f10bbfc7149: [lib] modify reaction message generatesNotifs function to return a pushType….

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
10 lines

Diff 23102

View Options

lib/shared/messages/reaction-message-spec.js

Loading...