Differential D6912
[Protos] Add UpdateUser definitions Authored by • jon on Feb 28 2023, 3:51 AM. Tags None Referenced Files
Details
gRPC definition of updateUser protocol This is primarily meant to garner feedback, while Notable differences from RegisterUser is that the This is mostly intended to be protocol oriented cd services/identity cargo build
Diff Detail
Event TimelineComment Actions could we just do exactly what we do for RegisterUser today with an additional check that the accessToken is valid? i understand wanting to make the code DRY and decoupling the parts a bit, but I'd rather we backlog that work and just get this out and working Comment Actions API looks good as far as I can tell, but I don't really understand the OPAQUE protocol definition so mostly deferring to you Comment Actions We need PakeRegistrationRequestAndUserID plus the existing access token for the user in the first UpdateUserRequest message, right? Comment Actions We talked about the usage of access tokens, and decided that we can defer doing access_token validation when the client (not keyserver) is able to provide them. Comment Actions Defer to you guys, I don't know enough about PAKE to comment on the .proto, and I don't know Rust so can't comment on the rest Comment Actions Let's capitalize Identity Service everywhere in the .proto file for consistency. otherwise looks good |