Page MenuHomePhabricator

[nix] Launch `redis-server` from `REDIS_CACHE_DIR`
ClosedPublic

Authored by atul on Mar 8 2023, 1:27 PM.
Tags
None
Referenced Files
F3357276: D7016.id23557.diff
Sat, Nov 23, 11:21 PM
F3357133: D7016.diff
Sat, Nov 23, 10:35 PM
F3357096: D7016.id23560.diff
Sat, Nov 23, 10:23 PM
F3355549: D7016.id23557.diff
Sat, Nov 23, 2:39 PM
F3354997: D7016.id23560.diff
Sat, Nov 23, 1:49 PM
Unknown Object (File)
Tue, Nov 19, 11:29 AM
Unknown Object (File)
Tue, Nov 19, 11:29 AM
Unknown Object (File)
Tue, Nov 19, 11:29 AM

Details

Reviewers
jon
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rCOMM8587565aae95: [nix] Launch `redis-server` from `REDIS_CACHE_DIR`
Summary

Redis will persist application files (eg dump.rdp) to disk from wherever it was launched. We're currently launching from the root of the repo, so I'm constantly getting a dump.rdp in my git working copy which is annoying (as would everyone else if they were actually using Redis/MariaDB via Nix...).

Instead we're cding to $REDIS_CACHE_DIR before launching Redis, so dump.rdp will live there and outside of the root of the repo.

Test Plan

dump.rdp appearing in $REDIS_CACHE_DIR instead of /comm after making this change + killing Redis:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Mar 8 2023, 1:27 PM
atul published this revision for review.Mar 8 2023, 1:28 PM
This revision is now accepted and ready to land.Mar 8 2023, 1:38 PM

Lol, I've added dump.rdb to .git/info/exclude to workaround this. Glad that you fixed this