Page MenuHomePhabricator
Differential D7049

[keyserver] Introduce `setCookieSignedIdentityKeysBlob`
ClosedPublic
Actions

Authored by atul on Mar 12 2023, 3:36 PM.
Tags
None
Referenced Files
F3362126: D7049.diff
Sun, Nov 24, 9:32 PM
Unknown Object (File)
Sat, Nov 9, 2:26 AM
Unknown Object (File)
Sat, Nov 9, 2:26 AM
Unknown Object (File)
Sat, Nov 9, 2:26 AM
Unknown Object (File)
Sat, Nov 9, 2:25 AM
Unknown Object (File)
Sat, Nov 9, 12:42 AM
Unknown Object (File)
Tue, Nov 5, 10:12 PM
Unknown Object (File)
Tue, Nov 5, 10:12 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
Commits
rCOMMddca0507e9c1: [keyserver] Introduce `setCookieSignedIdentityKeysBlob`
Summary

Introduce setCookieSignedIdentityKeysBlob to update signed_identity_keys column of row in cookies table with id=cookieID.

This is to update serverDB when client SIGNED_IDENTITY_KEYS_BLOB response is received.

Depends on D7048

Test Plan

Ran query of that form manually in query console and it worked as expected. Will be tested implicitly by subsequent diffs in this stack.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Mar 12 2023, 3:36 PM
atul edited the summary of this revision. (Show Details)Mar 12 2023, 3:36 PM
atul added a parent revision: D7048: [web] Use `signedIdentityKeysBlobSelector` in `SIWELoginForm`.
Harbormaster completed remote builds in B17265: Diff 23653.Mar 12 2023, 3:52 PM
atul requested review of this revision.Mar 12 2023, 3:52 PM
atul added a child revision: D7050: [keyserver] Introduce `isCookieMissingSignedIdentityKeysBlob`.Mar 12 2023, 4:15 PM
atul removed a reviewer: tomek.Mar 13 2023, 7:34 AM
ashoat accepted this revision.Mar 13 2023, 11:55 AM

I think this diff would be easier to review if you included this new function's usage in the same diff

keyserver/src/session/cookies.js
801–805

Nit: I find SQL to be more readable this way

This revision is now accepted and ready to land.Mar 13 2023, 11:55 AM
atul updated this revision to Diff 23725.Mar 14 2023, 10:00 AM

address feedback

keyserver/src/session/cookies.js
801–805

Definitely, will make that change before landing

This revision was landed with ongoing or failed builds.Mar 14 2023, 10:03 AM
Closed by commit rCOMMddca0507e9c1: [keyserver] Introduce `setCookieSignedIdentityKeysBlob` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMddca0507e9c1: [keyserver] Introduce `setCookieSignedIdentityKeysBlob`.
Harbormaster completed remote builds in B17323: Diff 23725.Mar 14 2023, 10:16 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
session/
13 lines

Diff 23653

View Options

keyserver/src/session/cookies.js

Loading...