This was the source of the issue ENG-3311, more information in the comments.
The short version is that if we checked for updates (and didn't find any) after downloading a new desktop version an error would appear when user tried to quit and update.
Details
Details
Check if the error stops happening.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
I'm confused – we're just deleting this? Can you provide more details on what it was supposed to do, and how that intent is handled now?
Comment Actions
This code was supposed to handle an edge case where:
- Electron downloads an update, and we display the modal
- Before the user presses the modal to quit-and-install, we release a new version.
Without this, the user will have to update the app twice instead of once (in this rare case).
Unfortunately, this code doesn't work (and is the cause of the ENG-3311 issue). I can't think of an easy way to replace this behavior. I can make a task to replace this code with something else but I don't think it should be a priority right now.