Page MenuHomePhabricator
Differential D7069

[native] render the rest of the user avatars
ClosedPublic
Actions

Authored by ginsu on Mar 14 2023, 2:03 PM.
Tags
None
Referenced Files
F3359724: D7069.diff
Sun, Nov 24, 10:37 AM
Unknown Object (File)
Wed, Nov 6, 3:36 PM
Unknown Object (File)
Wed, Nov 6, 3:36 PM
Unknown Object (File)
Wed, Nov 6, 3:36 PM
Unknown Object (File)
Mon, Nov 4, 11:32 PM
Unknown Object (File)
Mon, Nov 4, 11:32 PM
Unknown Object (File)
Mon, Nov 4, 11:32 PM
Unknown Object (File)
Mon, Nov 4, 11:32 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMM7dd079eabea8: [native] render the rest of the user avatars
Summary

Render the rest of the user avatars. Since the logic for rendering the remaining user avatars in our app was pretty similar, I decided to package it all in one diff

Depends on D7057

Linear Task: https://linear.app/comm/issue/ENG-3107/build-out-a-dummy-avatar-component-and-render-it-everywhere-we-will

Test Plan

Please look at the screenshots to see the changes I made:

Message reactions modal:

Screenshot 2023-03-14 at 5.07.33 PM.png (1×1 px, 795 KB)

Thread settings member:

Screenshot 2023-03-14 at 5.07.49 PM.png (1×1 px, 990 KB)

Typeahead tooltip:

Screenshot 2023-03-14 at 5.08.06 PM.png (1×1 px, 1 MB)

User list user:

Screenshot 2023-03-14 at 5.09.25 PM.png (1×1 px, 737 KB)

Screenshot 2023-03-14 at 5.08.50 PM.png (1×1 px, 745 KB)

Relationship list item:

Screenshot 2023-03-14 at 5.14.01 PM.png (1×1 px, 732 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Mar 14 2023, 2:03 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 14 2023, 2:03 PM
ginsu edited the summary of this revision. (Show Details)Mar 14 2023, 2:14 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, atul.
ginsu added a parent revision: D7067: [native] render user avatars in chat screen.
ginsu attached a referenced file: F427705: Screenshot 2023-03-14 at 5.14.01 PM.png. (Show Details)
ginsu attached a referenced file: F427699: Screenshot 2023-03-14 at 5.08.50 PM.png. (Show Details)
ginsu attached a referenced file: F427700: Screenshot 2023-03-14 at 5.09.25 PM.png. (Show Details)
ginsu attached a referenced file: F427694: Screenshot 2023-03-14 at 5.08.06 PM.png. (Show Details)
ginsu attached a referenced file: F427689: Screenshot 2023-03-14 at 5.07.49 PM.png. (Show Details)
ginsu attached a referenced file: F427681: Screenshot 2023-03-14 at 5.07.33 PM.png. (Show Details)
Harbormaster completed remote builds in B17332: Diff 23738.Mar 14 2023, 2:18 PM
ginsu requested review of this revision.Mar 14 2023, 2:18 PM
ashoat accepted this revision.Mar 15 2023, 1:53 PM

Seems uncontroversial

This revision is now accepted and ready to land.Mar 15 2023, 1:53 PM
ginsu added a child revision: D7099: [native] add feature flag to avatars render work.Mar 20 2023, 7:09 AM
ginsu updated this revision to Diff 23851.Mar 20 2023, 7:14 AM

rebase after switching up diff stack order

ginsu edited the summary of this revision. (Show Details)Mar 20 2023, 7:15 AM
ginsu added a parent revision: D7057: [native] render avatar in profile screen.
ginsu removed a parent revision: D7067: [native] render user avatars in chat screen.
Harbormaster completed remote builds in B17409: Diff 23851.Mar 20 2023, 7:30 AM
ginsu updated this revision to Diff 23899.Mar 20 2023, 3:25 PM

rebase before landing

Harbormaster failed remote builds in B17444: Diff 23899!Mar 20 2023, 3:38 PM
ginsu updated this revision to Diff 23940.Mar 21 2023, 8:52 AM

rebase after merge

Harbormaster completed remote builds in B17478: Diff 23940.Mar 21 2023, 9:08 AM
Closed by commit rCOMM7dd079eabea8: [native] render the rest of the user avatars (authored by ginsu). · Explain WhyMar 21 2023, 9:24 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM7dd079eabea8: [native] render the rest of the user avatars.

Revision Contents
Changeset List

Diff 23899

View Options

native/chat/message-reactions-modal.react.js

Loading...
View Options

native/chat/settings/thread-settings-member.react.js

Loading...
View Options

native/chat/typeahead-tooltip.react.js

Loading...
View Options

native/components/user-list-user.react.js

Loading...
View Options

native/profile/relationship-list-item.react.js

Loading...