Details

Reviewers

atul
tomek
• jon

Commits

rCOMM26c2d2f52e0b: [keyserver] Fix account deletion performance

Summary

Account deletion used to time out. After this it's basically instantaneous. The reports table is pretty huge...

More context here on Linear.

Test Plan

I ran it on prod and it fixed the issue

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/delete

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Mar 25 2023, 12:04 AM

I analyzed the queries we run on the reports table and found that creating a report runs this query, so I refined this index so it can help there as well. No other queries on reports seemed to do a full scan

Forgot to update createTables in the last revision

ashoat added a reviewer: • jon.Mar 25 2023, 12:20 AM

ashoat added inline comments.

keyserver/src/cron/cron.js
30 ↗	(On Diff #24106)	Not sure why I missed this one in D6334. The context is explained there
keyserver/src/database/migration-config.js
224 ↗	(On Diff #24106)	I already created this index on prod to test the fix, before I realized it would be better to have a more specific index. This part of the query should only affect prod

Harbormaster completed remote builds in B17610: Diff 24104.Mar 25 2023, 12:20 AM

Harbormaster completed remote builds in B17611: Diff 24105.Mar 25 2023, 12:31 AM

Harbormaster completed remote builds in B17612: Diff 24106.

ashoat requested review of this revision.Mar 25 2023, 12:31 AM

tomek accepted this revision.Mar 27 2023, 9:10 AM

tomek added inline comments.

keyserver/src/cron/cron.js
30 ↗	(On Diff #24106)	This is specific to a location of a keyserver, so we can also consider saying that it's in a keyserver's timezone instead of specifying a timezone explicitly.

This revision is now accepted and ready to land.Mar 27 2023, 9:10 AM

Clarify that it's in the timezone of the keyserver

This revision was landed with ongoing or failed builds.Mar 27 2023, 2:06 PM

Closed by commit rCOMM26c2d2f52e0b: [keyserver] Fix account deletion performance. · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM26c2d2f52e0b: [keyserver] Fix account deletion performance.

Harbormaster completed remote builds in B17675: Diff 24196.Mar 27 2023, 2:21 PM

[keyserver] Fix account deletion performance
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 24105

keyserver/src/cron/cron.js

keyserver/src/database/migration-config.js

keyserver/src/database/setup-db.js

[keyserver] Fix account deletion performanceClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24105

keyserver/src/cron/cron.js

keyserver/src/database/migration-config.js

keyserver/src/database/setup-db.js

[keyserver] Fix account deletion performance
ClosedPublic
Actions

Revision Contents
Changeset List