Page MenuHomePhabricator
Differential D7135

[native] render thread avatar in CHANNEL AVATAR thread settings section
ClosedPublic
Actions

Authored by ginsu on Mar 21 2023, 10:47 PM.
Tags
None
Referenced Files
F3384305: D7135.id24214.diff
Thu, Nov 28, 8:23 PM
F3384283: D7135.id23966.diff
Thu, Nov 28, 8:15 PM
F3380364: D7135.diff
Wed, Nov 27, 11:03 PM
Unknown Object (File)
Mon, Nov 25, 6:54 AM
Unknown Object (File)
Mon, Nov 25, 5:44 AM
Unknown Object (File)
Mon, Nov 25, 3:36 AM
Unknown Object (File)
Thu, Nov 14, 4:05 PM
Unknown Object (File)
Fri, Nov 8, 6:52 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMMf55b55b3fef7: [native] render thread avatar in CHANNEL AVATAR thread settings section
Summary

Introduce CHANNEL AVATAR section in thread settings and render thread avatar in this new section

Depends on D7134

Test Plan

Please take a look at the screenshots to see the changes I made:

staff user:

Screenshot 2023-03-22 at 3.34.29 AM.png (1×1 px, 816 KB)

non staff user:

Screenshot 2023-03-22 at 3.34.54 AM.png (1×1 px, 611 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Mar 21 2023, 10:47 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 21 2023, 10:47 PM
Harbormaster completed remote builds in B17498: Diff 23966.Mar 21 2023, 11:02 PM
ginsu requested review of this revision.Mar 21 2023, 11:02 PM
ginsu edited the summary of this revision. (Show Details)Mar 22 2023, 12:35 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, atul.
ginsu added a parent revision: D7134: [native] update message list header to new design.
ginsu attached a referenced file: F439887: Screenshot 2023-03-22 at 3.34.29 AM.png. (Show Details)
ginsu attached a referenced file: F439888: Screenshot 2023-03-22 at 3.34.54 AM.png. (Show Details)
ginsu updated this revision to Diff 23972.Mar 22 2023, 12:45 AM
ginsu edited the test plan for this revision. (Show Details)

update prop types for thread settings avatar

ginsu added a child revision: D7136: [native] render thread avatars in community drawer.Mar 22 2023, 12:54 AM
Harbormaster completed remote builds in B17504: Diff 23972.Mar 22 2023, 1:00 AM
ashoat accepted this revision.Mar 22 2023, 12:29 PM
ashoat added inline comments.
native/chat/settings/thread-settings-avatar.react.js
19 ↗(On Diff #23972)

You could skip this memo and even improve performance slightly by just wrapping the whole component in React.memo

This revision is now accepted and ready to land.Mar 22 2023, 12:29 PM
ginsu updated this revision to Diff 24143.EditedMar 26 2023, 12:05 AM

address feedback

Harbormaster completed remote builds in B17641: Diff 24143.Mar 26 2023, 12:20 AM
ginsu updated this revision to Diff 24214.Mar 27 2023, 8:19 AM

rebase before landing

Harbormaster completed remote builds in B17691: Diff 24214.Mar 27 2023, 8:34 AM
Closed by commit rCOMMf55b55b3fef7: [native] render thread avatar in CHANNEL AVATAR thread settings section (authored by ginsu). · Explain WhyMar 27 2023, 8:44 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMf55b55b3fef7: [native] render thread avatar in CHANNEL AVATAR thread settings section.

Revision Contents
Changeset List

PathSize
native/
chat/
settings/
38 lines
32 lines

Diff 24219

View Options

native/chat/settings/thread-settings-avatar.react.js

Loading...
View Options

native/chat/settings/thread-settings.react.js

Loading...