[native] render the rest of the thread avatars
ClosedPublic
Actions

Authored by ginsu on Mar 21 2023, 10:52 PM.

Details

Reviewers

ashoat
atul

Commits

rCOMM086416ce36d8: [native] render the rest of the thread avatars

Summary

rendered the rest of thread avatars which included the thread list thread and the chat thread list item

Depends on D7137

Test Plan

Please check out the screenshots to see the changes that I made:

Thread list:

staff user:

Screenshot 2023-03-22 at 4.01.00 AM.png (1×1 px, 814 KB)

non staff user:

Screenshot 2023-03-22 at 4.02.25 AM.png (1×1 px, 773 KB)

Chat thread list:

staff user:

Screenshot 2023-03-22 at 4.01.48 AM.png (1×1 px, 917 KB)

non staff user:

Screenshot 2023-03-22 at 4.02.27 AM.png (1×1 px, 862 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Mar 21 2023, 10:52 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 21 2023, 10:52 PM

Harbormaster completed remote builds in B17501: Diff 23969.Mar 21 2023, 11:08 PM

ginsu requested review of this revision.Mar 21 2023, 11:08 PM

ginsu edited the summary of this revision. (Show Details)Mar 22 2023, 1:03 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: ashoat, atul.

ginsu added a parent revision: D7137: [native] render thread avatars for parent/child threads in thread settings.

ginsu attached a referenced file: F439938: Screenshot 2023-03-22 at 4.02.27 AM.png. (Show Details)

ginsu attached a referenced file: F439936: Screenshot 2023-03-22 at 4.01.48 AM.png. (Show Details)

ginsu attached a referenced file: F439937: Screenshot 2023-03-22 at 4.02.25 AM.png. (Show Details)

ginsu attached a referenced file: F439935: Screenshot 2023-03-22 at 4.01.00 AM.png. (Show Details)

ashoat accepted this revision.Mar 22 2023, 1:56 PM

This revision is now accepted and ready to land.Mar 22 2023, 1:56 PM

rebase before landing

Harbormaster completed remote builds in B17710: Diff 24242.Mar 27 2023, 3:34 PM

Closed by commit rCOMM086416ce36d8: [native] render the rest of the thread avatars (authored by ginsu). · Explain WhyMar 27 2023, 3:38 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM086416ce36d8: [native] render the rest of the thread avatars.

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-thread-list-item.react.js

17 lines

components/

thread-list-thread.react.js

20 lines

Diff 24242

View Options

native/chat/chat-thread-list-item.react.js