[native] update Image import to use expo-image in Multimedia component
ClosedPublic
Actions

Authored by ginsu on Mar 29 2023, 3:47 PM.

Details

Reviewers

ashoat
atul

Commits

rCOMM17181153bdc9: [native] update Image import to use expo-image in Multimedia component

Summary

As I was working with ens avatars today I noticed that we were still using the Image component from react-native and not expo-image, which was causing some rendering issues while I was tinkering

Test Plan

Every place we use Multimedia still renders and I was able to get the ens avatar to render in Mutlimedia which was using a svg data uri

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Mar 29 2023, 3:47 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 29 2023, 3:47 PM

ginsu added reviewers: ashoat, atul.Mar 29 2023, 3:48 PM

ginsu added a child revision: D7187: [native] extend avatar component to handle images.Mar 29 2023, 4:02 PM

Harbormaster completed remote builds in B17796: Diff 24350.Mar 29 2023, 4:03 PM

ginsu requested review of this revision.Mar 29 2023, 4:03 PM

atul accepted this revision.Mar 29 2023, 8:59 PM

This revision is now accepted and ready to land.Mar 29 2023, 8:59 PM

Thanks for fixing this!

Closed by commit rCOMM17181153bdc9: [native] update Image import to use expo-image in Multimedia component (authored by ginsu). · Explain WhyMar 30 2023, 8:14 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM17181153bdc9: [native] update Image import to use expo-image in Multimedia component.

Revision Contents
Changeset List

Path

Size

native/

media/

multimedia.react.js

3 lines

Diff 24350

View Options

native/media/multimedia.react.js

[native] update Image import to use expo-image in Multimedia componentClosedPublicActions