Extended avatar component to either render an emoji avatar or image avatar depending on avatarInfo.type.
Since Multimedia only uses type and uri from mediaInfo, I only included those fields in the AvatarMediaInfo type.
Depends on D7245
Details
Details
To test if the image was rendering correctly, I injected the following as the avatarInfo:
const avatarInfo = { type: 'image', uri: 'https://picsum.photos/200' };
Please see the screenshots to see how the image avatar looks for each size:
Profile:
Large:
Small:
Micro:
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/components/avatar.react.js | ||
|---|---|---|
| 53 ↗ | (On Diff #24179) | Been thinking/trying to figure this out for a while now, and I would appreciate some guidance with the following here... Hopefully, the comment below makes sense and explains my thinking, but lmk if not |
| 55 ↗ | (On Diff #24179) | It seems like, based on this line in RemoteImage making onLoad optional should be totally possible |
| 59 ↗ | (On Diff #24179) | |
Comment Actions
Resubmitting annotations so it's easier to see on this diff
| native/components/avatar.react.js | ||
|---|---|---|
| 53 ↗ | (On Diff #24186) | Been thinking/trying to figure this out for a while now, and I would appreciate some guidance with the following here... Hopefully, the comment below makes sense and explains my thinking, but lmk if not |
| 55 ↗ | (On Diff #24186) | It seems like, based on this line in RemoteImage making onLoad optional should be totally possible |
| 59 ↗ | (On Diff #24186) | |
Comment Actions
Is this diff still in [draft] state? Or is it ready to review?
Can you remove [draft] from title and re-request review if it's ready and I'll take a look?
Comment Actions
Is this diff still in [draft] state? Or is it ready to review?
There is just one question I still have in the diff I was hoping to get your or @ashoat's 2 cents on. Sorry, I should have made that more apparent in the description. So not ready for review, but I wasn't sure what the best way to show you guys my code was besides putting up a "draft diff". For the future, is there a better way to show my code and ask questions about it than this?
| native/components/avatar.react.js | ||
|---|---|---|
| 81–85 ↗ | (On Diff #24353) | Could maybe do return shouldRenderAvatars ? avatar : null; but up to you. |