[native] improve avatar component prop types
ClosedPublic
Actions

Authored by ginsu on Mar 30 2023, 11:13 PM.

Details

Reviewers

ashoat
atul

Commits

rCOMM4f3bfe4ae202: [native] improve avatar component prop types

Summary

Minor changes to improve the prop types of Avatar. Also made order of size from smallest to biggest (probably should have done this from the start) to improve readability

Depends on D7264

Test Plan

flow and all avatars still render

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Mar 30 2023, 11:13 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 30 2023, 11:13 PM

ginsu edited the summary of this revision. (Show Details)Mar 30 2023, 11:17 PM

ginsu added reviewers: ashoat, atul.

ginsu added a parent revision: D7264: [lib/native] change useGetAvatarForThread to useAvatarForThread.

Harbormaster completed remote builds in B17859: Diff 24458.Mar 30 2023, 11:28 PM

ginsu requested review of this revision.Mar 30 2023, 11:28 PM

ashoat accepted this revision.Mar 31 2023, 5:36 AM

This revision is now accepted and ready to land.Mar 31 2023, 5:36 AM

rebase before landing

Harbormaster completed remote builds in B17897: Diff 24513.Mar 31 2023, 8:57 AM

Closed by commit rCOMM4f3bfe4ae202: [native] improve avatar component prop types (authored by ginsu). · Explain WhyMar 31 2023, 9:43 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM4f3bfe4ae202: [native] improve avatar component prop types.

Revision Contents
Changeset List

Path

Size

native/

components/

avatar.react.js

26 lines

Diff 24458

View Options

native/components/avatar.react.js

[native] improve avatar component prop typesClosedPublicActions