Page MenuHomePhabricator
Differential D7199

[keyserver] Add pinned_count column to MariaDB threads table
ClosedPublic
Actions

Authored by rohan on Mar 27 2023, 9:50 AM.
Tags
None
Referenced Files
F3379601: D7199.diff
Wed, Nov 27, 5:30 PM
Unknown Object (File)
Sat, Nov 16, 5:39 PM
Unknown Object (File)
Sun, Nov 10, 7:12 PM
Unknown Object (File)
Sun, Nov 10, 4:43 PM
Unknown Object (File)
Sun, Nov 10, 4:40 PM
Unknown Object (File)
Sun, Nov 10, 2:28 PM
Unknown Object (File)
Sun, Nov 10, 2:20 PM
Unknown Object (File)
Sun, Nov 10, 7:25 AM
View All Files
Subscribers
None

Details

Reviewers
atul
ginsu
tomek
ashoat
Commits
rCOMM85b25b439922: [keyserver] Add pinned_count column to MariaDB threads table
Summary

We need to include a pinned_count column to the threads table in MariaDB in order to include it in the thread info in a later diff. Modifications to the client db and the new thread types / persist migration will come in the next two diffs

Part of
https://linear.app/comm/issue/ENG-3396/store-the-number-of-pinned-messages-in-threadinfo

Depends on D6924

Test Plan

Run the migration and confirm that the pinned_count column appears in MariaDB

Screenshot 2023-03-27 at 12.50.47 PM.png (990×3 px, 395 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan created this revision.Mar 27 2023, 9:50 AM
rohan edited the summary of this revision. (Show Details)Mar 27 2023, 9:51 AM
rohan edited the test plan for this revision. (Show Details)
rohan attached a referenced file: F447926: Screenshot 2023-03-27 at 12.50.47 PM.png. (Show Details)
rohan edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B17697: Diff 24223.Mar 27 2023, 10:06 AM
rohan requested review of this revision.Mar 27 2023, 10:06 AM
rohan added a child revision: D7202: [native] Add pinned_count column to SQLite threads table.Mar 27 2023, 12:01 PM
ashoat accepted this revision.Mar 27 2023, 4:23 PM
This revision is now accepted and ready to land.Mar 27 2023, 4:23 PM
rohan updated this revision to Diff 24498.Mar 31 2023, 4:17 AM

Rebase

Harbormaster completed remote builds in B17883: Diff 24498.Mar 31 2023, 4:43 AM
rohan removed a parent revision: D7175: [lib] Include an isPinned flag in ChatMessageInfoItem.Apr 7 2023, 8:27 AM
rohan removed a child revision: D7202: [native] Add pinned_count column to SQLite threads table.
rohan added a child revision: D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.Apr 7 2023, 8:29 AM
rohan added a parent revision: D6924: [keyserver] Introduce columns in messages table to support pinned messages.
rohan added a child revision: D7202: [native] Add pinned_count column to SQLite threads table.Apr 7 2023, 8:54 AM
rohan removed a child revision: D7202: [native] Add pinned_count column to SQLite threads table.Apr 7 2023, 8:59 AM
rohan added a child revision: D7202: [native] Add pinned_count column to SQLite threads table.Apr 7 2023, 2:26 PM
rohan removed a child revision: D7202: [native] Add pinned_count column to SQLite threads table.Apr 7 2023, 2:32 PM
rohan edited the summary of this revision. (Show Details)Apr 7 2023, 3:09 PM
rohan updated this revision to Diff 24867.Apr 7 2023, 3:10 PM

Rebase before landing

Harbormaster completed remote builds in B18163: Diff 24867.Apr 7 2023, 3:26 PM
rohan updated this revision to Diff 24980.Apr 11 2023, 8:44 AM

Rebase before landing

Harbormaster completed remote builds in B18237: Diff 24980.Apr 11 2023, 9:00 AM
Closed by commit rCOMM85b25b439922: [keyserver] Add pinned_count column to MariaDB threads table (authored by RohanK6 <rohan.khanderia@gmail.com>). · Explain WhyApr 11 2023, 9:00 AM
This revision was automatically updated to reflect the committed changes.
RohanK6 <rohan.khanderia@gmail.com> added a commit: rCOMM85b25b439922: [keyserver] Add pinned_count column to MariaDB threads table.

Revision Contents
Changeset List

PathSize
keyserver/
src/
database/
9 lines
3 lines

Diff 24498

View Options

keyserver/src/database/migration-config.js

Loading...
View Options

keyserver/src/database/setup-db.js

Loading...