[CommCoreModule] Handle `thread.avatar` in `parseDBThreads`
ClosedPublic
Actions

Authored by atul on Apr 3 2023, 6:28 AM.

Details

Reviewers

ginsu
ashoat

Commits

rCOMMfbe40140555d: [CommCoreModule] Handle `thread.avatar` in `parseDBThreads`

Summary

So we can "pull out" avatar stored in SQLite.

Test Plan

Log jsiThreads in parseDBThreads and check return value of CommCoreModule.getAllThreads(...) on the JSI side.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 3 2023, 6:28 AM

Herald added a subscriber: tomek. · View Herald TranscriptApr 3 2023, 6:28 AM

fix

atul published this revision for review.Apr 3 2023, 6:37 AM

Harbormaster completed remote builds in B17943: Diff 24575.Apr 3 2023, 6:45 AM

Harbormaster completed remote builds in B17944: Diff 24576.Apr 3 2023, 6:54 AM

ashoat accepted this revision.Apr 3 2023, 1:53 PM

This revision is now accepted and ready to land.Apr 3 2023, 1:53 PM

rebase before landing

Harbormaster completed remote builds in B17950: Diff 24585.Apr 3 2023, 2:27 PM

Closed by commit rCOMMfbe40140555d: [CommCoreModule] Handle `thread.avatar` in `parseDBThreads` (authored by atul). · Explain WhyApr 3 2023, 2:41 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMfbe40140555d: [CommCoreModule] Handle `thread.avatar` in `parseDBThreads`.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.cpp

5 lines

Diff 24575

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

[CommCoreModule] Handle `thread.avatar` in `parseDBThreads`ClosedPublicActions