[keyserver] Update `fetchServerThreadInfos` to include `avatar` field
ClosedPublic
Actions

Authored by atul on Apr 6 2023, 12:04 PM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMM08b9d725b65e: [keyserver] Update `fetchServerThreadInfos` to include `avatar` field

Summary

Modify fetchServerThreadInfos to include avatar (if it exists) in response from fetchServerThreadInfos query.

Depends on D7332

Test Plan

Set breakpoints and verified that avatar field was included in constructed object:

Verified that Redux state was updated to include avatar field (as result of updateThread => commitMembershipChangeset => rawThreadInfosFromServerThreadInfos => createUpdates):

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D7333 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 6 2023, 12:04 PM

Herald added a subscriber: tomek. · View Herald TranscriptApr 6 2023, 12:04 PM

atul added a child revision: D7334: [lib] Update `ChangeSettingsMessageSpec` robotext for `avatar` update.Apr 6 2023, 12:05 PM

atul published this revision for review.Apr 6 2023, 12:17 PM

Harbormaster completed remote builds in B18057: Diff 24743.Apr 6 2023, 12:21 PM

atul edited the test plan for this revision. (Show Details)Apr 6 2023, 12:23 PM

ashoat accepted this revision.Apr 6 2023, 12:40 PM

ashoat added inline comments.

lib/types/thread-types.js
282 ↗	(On Diff #24743)	Is the second question mark necessary here? It seems to me like if the `avatar` property exists, it will not be falsey (but I might be missing something) (I guess the other types have the second question mark, and it doesn't really affect much) Separately, it might be a good idea to place it in the same place where it is in the other types (after `name`)

This revision is now accepted and ready to land.Apr 6 2023, 12:40 PM

atul added inline comments.Apr 6 2023, 2:16 PM

lib/types/thread-types.js
282 ↗	(On Diff #24743)	No second question mark isn't necessary. After thinking through old clients we concluded that `avatar` should either be A. truthy `AvatarDBContent` B. excluded from `ThreadInfo`/`UserInfo` altogether Will remove here before landing, and reconsider the other instances of `?AvatarDBContent`. Good point, will reposition before landing.