Page MenuHomePhabricator
Differential D7376

[keyserver] Introduce `assignThreadContainerToMedia`
AbandonedPublic
Actions

Authored by atul on Apr 10 2023, 12:12 PM.
Tags
None
Referenced Files
F3360480: D7376.id24920.diff
Sun, Nov 24, 12:48 PM
F3359685: D7376.diff
Sun, Nov 24, 10:23 AM
F3356392: D7376.diff
Sat, Nov 23, 6:45 PM
Unknown Object (File)
Tue, Nov 19, 5:24 AM
Unknown Object (File)
Mon, Nov 18, 11:30 PM
Unknown Object (File)
Mon, Nov 18, 10:35 AM
Unknown Object (File)
Mon, Nov 18, 7:17 AM
Unknown Object (File)
Fri, Nov 8, 9:24 PM
View All 80 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Summary

assignThreadContainerToMedia will be used as part of updateThread in subsequent diff to handle image thread avatars.

NOTE: We're intentionally not setting the thread field of the upload row because we don't want the avatar to show up in the result set of fetchMediaForThread.

Depends on D7375

Test Plan
  1. Created dummy entry in uploads table.
  2. Ran query to ensure container was correctly set.
  3. Deleted dummy entry.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 10 2023, 12:12 PM
Herald added a subscriber: tomek. · View Herald TranscriptApr 10 2023, 12:12 PM
atul edited the summary of this revision. (Show Details)Apr 10 2023, 12:12 PM
atul added a parent revision: D7375: [keyserver] Introduce `assignUserContainerToMedia`.
atul added a child revision: D7377: [keyserver] Update `deleteThread` and `deleteInaccessibleThreads` to handle thread image avatars.
atul published this revision for review.Apr 10 2023, 12:16 PM
Harbormaster completed remote builds in B18200: Diff 24920.Apr 10 2023, 12:28 PM
ashoat requested changes to this revision.Apr 10 2023, 1:25 PM

Where is this used? Can you include the usage in this diff please? It's hard to review these standalone functions without seeing how they're used

This revision now requires changes to proceed.Apr 10 2023, 1:25 PM
atul abandoned this revision.Apr 10 2023, 1:26 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
updaters/
19 lines

Diff 24920

View Options

keyserver/src/updaters/upload-updaters.js

Loading...