Page MenuHomePhabricator

[keyserver] Update `deleteAccount` to handle user image avatars
ClosedPublic

Authored by atul on Apr 10 2023, 1:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 5:52 AM
Unknown Object (File)
Apr 3 2024, 4:15 PM
Unknown Object (File)
Apr 3 2024, 4:15 PM
Unknown Object (File)
Apr 3 2024, 4:15 PM
Unknown Object (File)
Apr 3 2024, 4:13 PM
Unknown Object (File)
Mar 8 2024, 1:54 AM
Unknown Object (File)
Mar 8 2024, 1:54 AM
Unknown Object (File)
Mar 7 2024, 7:49 AM
Subscribers

Details

Summary

I looked through all of the DELETE queries in keyserver to see where we're handling the deletion of users. I found one query (deleteAccount) that needed to be updated to handle deletion of user image avatar (AKA upload with container=deletedUserID)


Depends on D7377

Test Plan
  1. Set image avatar for user.
  2. Observe that container is set correctly in uploads table.
  3. Delete user.
  4. Observe that row in uploads table corresponding to user's image avatar has been removed.

This is safe because uploads has an index on container

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Apr 10 2023, 1:14 PM

This is safe because uploads has an index on container (would be good to note this in your Test Plan)

This revision is now accepted and ready to land.Apr 10 2023, 1:29 PM
atul edited the test plan for this revision. (Show Details)

rebase and alnd

This revision was landed with ongoing or failed builds.Apr 11 2023, 8:27 AM
This revision was automatically updated to reflect the committed changes.