Page MenuHomePhabricator
Differential D7379

[keyserver] Update `deleteAccount` to handle user image avatars
ClosedPublic
Actions

Authored by atul on Apr 10 2023, 1:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 8:40 AM
Unknown Object (File)
Mon, Nov 18, 8:14 AM
Unknown Object (File)
Mon, Nov 18, 8:07 AM
Unknown Object (File)
Mon, Nov 18, 7:06 AM
Unknown Object (File)
Mon, Nov 18, 6:57 AM
Unknown Object (File)
Mon, Nov 18, 6:56 AM
Unknown Object (File)
Mon, Nov 18, 6:25 AM
Unknown Object (File)
Fri, Nov 8, 9:24 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM12072c45140d: [keyserver] Update `deleteAccount` to handle user image avatars
Summary

I looked through all of the DELETE queries in keyserver to see where we're handling the deletion of users. I found one query (deleteAccount) that needed to be updated to handle deletion of user image avatar (AKA upload with container=deletedUserID)

Depends on D7377

Test Plan
  1. Set image avatar for user.
  2. Observe that container is set correctly in uploads table.
  3. Delete user.
  4. Observe that row in uploads table corresponding to user's image avatar has been removed.

This is safe because uploads has an index on container

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D7379 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 10 2023, 1:14 PM
Herald added a subscriber: tomek. · View Herald TranscriptApr 10 2023, 1:14 PM
atul published this revision for review.Apr 10 2023, 1:14 PM
ashoat accepted this revision.Apr 10 2023, 1:29 PM

This is safe because uploads has an index on container (would be good to note this in your Test Plan)

This revision is now accepted and ready to land.Apr 10 2023, 1:29 PM
atul edited the test plan for this revision. (Show Details)Apr 10 2023, 1:30 PM
Harbormaster completed remote builds in B18204: Diff 24928.Apr 10 2023, 1:31 PM
atul updated this revision to Diff 24977.Apr 11 2023, 8:26 AM
atul edited the test plan for this revision. (Show Details)

rebase and alnd

This revision was landed with ongoing or failed builds.Apr 11 2023, 8:27 AM
Closed by commit rCOMM12072c45140d: [keyserver] Update `deleteAccount` to handle user image avatars (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM12072c45140d: [keyserver] Update `deleteAccount` to handle user image avatars.
Harbormaster completed remote builds in B18235: Diff 24977.Apr 11 2023, 8:42 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
deleters/
4 lines

Diff 24977

View Options

keyserver/src/deleters/account-deleters.js

Loading...