Paths

Table of Contentst

Differential D7477

[native] Get rid of `mediaProcessConfig` and pass `processMedia` config directly
ClosedPublic
Actions

Authored by atul on Apr 17 2023, 3:21 PM.

Tags

None

Referenced Files

	F3407214: D7477.id25260.diff
	Wed, Dec 4, 4:46 AM

	F3407201: D7477.id25235.diff
	Wed, Dec 4, 4:39 AM

	F3407123: D7477.id25259.diff
	Wed, Dec 4, 4:10 AM

	F3404975: D7477.diff
	Tue, Dec 3, 3:47 PM

	Unknown Object (File)
	Sat, Nov 9, 8:36 PM

	Unknown Object (File)
	Sat, Nov 9, 8:36 PM

	Unknown Object (File)
	Sat, Nov 9, 8:36 PM

	Unknown Object (File)
	Fri, Nov 8, 9:22 PM

View All 60 Files

Subscribers

Details

Reviewers

ashoat
ginsu

Commits

rCOMM6ee32d15dceb: [native] Get rid of `mediaProcessConfig` and pass `processMedia` config directly

Summary

Originally, I just moved the definition of onTranscodingProgress outside of the mediaProcessConfig function: D7475... but on second thought I think we can remove mediaProcessConfig altogether.

Constructing the MediaProcessConfig directly is a lot simpler and removes unnecesary indirection.

(I'm NOT planning any other InputStateContainer refactors. Noticed this because I was looking specifically at processMedia for image avatar work and it was a 2min change)

Test Plan

flow/careful reading

transcoding progress appears correctly:

35b267.png (534×598 px, 258 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Apr 17 2023, 3:21 PM

Herald added a subscriber: tomek. · View Herald TranscriptApr 17 2023, 3:21 PM

Harbormaster completed remote builds in B18422: Diff 25235.Apr 17 2023, 3:40 PM

atul requested review of this revision.Apr 17 2023, 3:40 PM

atul edited the test plan for this revision. (Show Details)Apr 17 2023, 3:41 PM

atul edited the test plan for this revision. (Show Details)

atul attached a referenced file: F492344: 35b267.png. (Show Details)

ashoat accepted this revision.Apr 18 2023, 5:22 AM

This revision is now accepted and ready to land.Apr 18 2023, 5:22 AM

rebase and land

This revision was landed with ongoing or failed builds.Apr 18 2023, 7:09 AM

Closed by commit rCOMM6ee32d15dceb: [native] Get rid of `mediaProcessConfig` and pass `processMedia` config directly (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM6ee32d15dceb: [native] Get rid of `mediaProcessConfig` and pass `processMedia` config directly.

Harbormaster completed remote builds in B18444: Diff 25259.Apr 18 2023, 7:19 AM

Revision Contents
Changeset List

Path

Size

native/

input/

input-state-container.react.js

28 lines

Diff 25260

native/input/input-state-container.react.js

Loading...