Paths

Table of Contentst

Differential D7492

[native] Naively split `EditAvatar` into `EditUserAvatar` and `EditThreadAvatar`
ClosedPublic
Actions

Authored by atul on Apr 18 2023, 9:56 AM.

Tags

None

Referenced Files

	F3401085: D7492.diff
	Mon, Dec 2, 10:24 AM

	Unknown Object (File)
	Oct 31 2024, 12:25 PM

	Unknown Object (File)
	Oct 31 2024, 12:25 PM

	Unknown Object (File)
	Oct 31 2024, 12:24 PM

	Unknown Object (File)
	Oct 31 2024, 12:19 PM

	Unknown Object (File)
	Oct 20 2024, 3:24 PM

	Unknown Object (File)
	Sep 26 2024, 11:46 AM

	Unknown Object (File)
	Sep 7 2024, 1:40 AM

View All 52 Files

Subscribers

Details

Reviewers

ashoat
ginsu

Commits

rCOMM7cc483349a86: [native] Naively split `EditAvatar` into `EditUserAvatar` and `EditThreadAvatar`

Summary

We just copy the existing contents of EditAvatar and paste into EditUserAvatar and EditThreadAvatar and update imports.

In subsequent diffs we will:

Move UserAvatar and ThreadAvatar "into" EditUserAvatar and EditThreadAvatar respectively instead of passing in React.Node prop.
Pull out common functionality to hooks
Introduce user/avatar-specific functionality
Once everything is working, consider introducing some sort of BaseEditAvatar with some of the common styling/layout stuff (eg pencil icon). Defer this until the end once we have everything working.

Depends on D7491

Test Plan

App appears to work as before. Flow/ESLint to check imports.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Apr 18 2023, 9:56 AM

Herald added a subscriber: tomek. · View Herald TranscriptApr 18 2023, 9:56 AM

atul edited the summary of this revision. (Show Details)Apr 18 2023, 9:57 AM

atul added a parent revision: D7491: [native] Move vector-related components to `native/vectors`.

Harbormaster completed remote builds in B18464: Diff 25284.Apr 18 2023, 10:14 AM

atul requested review of this revision.Apr 18 2023, 10:14 AM

ginsu accepted this revision.Apr 18 2023, 10:21 AM

This revision is now accepted and ready to land.Apr 18 2023, 10:21 AM

Closed by commit rCOMM7cc483349a86: [native] Naively split `EditAvatar` into `EditUserAvatar` and `EditThreadAvatar` (authored by atul). · Explain WhyApr 18 2023, 10:26 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM7cc483349a86: [native] Naively split `EditAvatar` into `EditUserAvatar` and `EditThreadAvatar`.

Revision Contents
Changeset List

Path

Size

native/

avatars/

edit-avatar.react.js

	edit-thread-avatar.react.js
	edit-avatar.react.js

4 lines

	edit-user-avatar.react.js
	edit-avatar.react.js

4 lines

chat/

settings/

thread-settings-avatar.react.js

6 lines

profile/

profile-screen.react.js

8 lines

Diff 25290

native/avatars/edit-avatar.react.js

Loading...

native/avatars/edit-thread-avatar.react.js

Loading...

native/avatars/edit-user-avatar.react.js

Loading...

native/chat/settings/thread-settings-avatar.react.js

Loading...

native/profile/profile-screen.react.js

Loading...