Page MenuHomePhabricator
Differential D7554

[native] introduce useUploadSelectedMedia hook
ClosedPublic
Actions

Authored by ginsu on Apr 20 2023, 12:25 PM.
Tags
None
Referenced Files
F3394993: D7554.diff
Sun, Dec 1, 12:49 AM
Unknown Object (File)
Thu, Nov 28, 12:47 PM
Unknown Object (File)
Thu, Nov 28, 12:32 PM
Unknown Object (File)
Thu, Nov 28, 10:42 AM
Unknown Object (File)
Fri, Nov 22, 3:39 AM
Unknown Object (File)
Sun, Nov 10, 1:08 PM
Unknown Object (File)
Fri, Nov 8, 2:38 AM
Unknown Object (File)
Mon, Nov 4, 11:15 AM
View All 71 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMM9081f2d40dba: [native] introduce useUploadSelectedMedia hook
Summary

First step in the great avatars refactor/cleanup. Created this diff to factor out all the logic for uploading and preparing an image selection to be saved by the set avatar endpoints, which was really long and making it difficult to read/work in the avatar-hooks file.

Test Plan

Tested that I could still upload image avatar through this hook, and that the correct loading states for either user avatar or thread avatars were being changed during the image avatar creation flow

Diff Detail

Repository
rCOMM Comm
Branch
avatars-cleanup
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Apr 20 2023, 12:25 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 20 2023, 12:25 PM
ginsu edited the summary of this revision. (Show Details)Apr 20 2023, 12:27 PM
ginsu added reviewers: ashoat, atul.
ginsu added inline comments.Apr 20 2023, 12:30 PM
native/avatars/avatar-hooks.js
139

This is a temporary solution until we introduce an edit avatar context/provider. Again I wanted to create this diff first this file a bit easier to read/work in.

Harbormaster completed remote builds in B18593: Diff 25469.Apr 20 2023, 12:43 PM
ginsu requested review of this revision.Apr 20 2023, 12:43 PM
ginsu added inline comments.Apr 20 2023, 1:16 PM
native/avatars/avatar-hooks.js
320–326

Completely removed this from useUploadSelectedMedia since this will always be false and is unnecessary

ashoat accepted this revision.Apr 21 2023, 6:13 AM
ashoat added inline comments.
native/avatars/avatar-hooks.js
177

I'm not 100% sure but you might be able to do this

214–216

I think this can be defined below updateUserAvatarLoadingStatus. It's weird defining it in between logic that is otherwise dedicated to inProgress

This revision is now accepted and ready to land.Apr 21 2023, 6:13 AM
ginsu updated this revision to Diff 25551.Apr 21 2023, 11:36 AM
ginsu edited the summary of this revision. (Show Details)

address comments/rebase before landing

Harbormaster completed remote builds in B18660: Diff 25551.Apr 21 2023, 11:55 AM
Closed by commit rCOMM9081f2d40dba: [native] introduce useUploadSelectedMedia hook (authored by ginsu). · Explain WhyApr 21 2023, 11:58 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM9081f2d40dba: [native] introduce useUploadSelectedMedia hook.

Revision Contents
Changeset List

PathSize
native/
avatars/
180 lines

Diff 25469

View Options

native/avatars/avatar-hooks.js

Loading...