Details

Reviewers

ashoat
ginsu

Commits

rCOMM815e8fd7c6ce: [native] Return without error if avatar image `selection` is empty

Summary

Context: https://linear.app/comm/issue/ENG-3803/error-message-when-user-exits-the-select-image-flow-for-avatar

We want to return silently instead of throwing exception + displaying alert.

Test Plan

Select image
Close image gallery without picking an image
Observe no alert

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 26 2023, 3:23 PM

Herald added a subscriber: tomek. · View Herald TranscriptApr 26 2023, 3:23 PM

Harbormaster completed remote builds in B18825: Diff 25793.Apr 26 2023, 3:41 PM

atul requested review of this revision.Apr 26 2023, 3:41 PM

I think it would also be good to update uploadSelectedMedia's parameter type which is currently ?MediaLibrarySelection to just MediaLibrarySelection in this diff as well

This revision now requires changes to proceed.Apr 26 2023, 4:38 PM

In D7638#226562, @ginsu wrote:

I think it would also be good to update uploadSelectedMedia's parameter type which is currently ?MediaLibrarySelection to just MediaLibrarySelection in this diff as well

True, will update in a sec

address feedback

Harbormaster completed remote builds in B18887: Diff 25867.Apr 27 2023, 10:38 AM

ginsu accepted this revision.Apr 27 2023, 1:36 PM

This revision is now accepted and ready to land.Apr 27 2023, 1:36 PM

update

rebase and alnd

This revision was landed with ongoing or failed builds.Apr 28 2023, 11:00 AM

Closed by commit rCOMM815e8fd7c6ce: [native] Return without error if avatar image `selection` is empty (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM815e8fd7c6ce: [native] Return without error if avatar image `selection` is empty.

Harbormaster completed remote builds in B18914: Diff 25907.Apr 28 2023, 11:16 AM