Because we're using updatesForCurrentSession: 'return' these updates will NOT be sent for current session. This is for other sessions where the user might be logged in.
Details
Details
Works as expected:
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| keyserver/src/updaters/account-updaters.js | ||
|---|---|---|
| 210 | Nit: can we make this the first param? Usually we have Viewer as the first param (unless it's optional) | |
| 213–215 | Let's not filter the current viewer. That way we'll get the update via updatesForCurrentSession: 'return', and return to the client directly | |
| 231 | Let's just have a single createUpdates, with the full array and the ViewerInfo in this invocation here | |
| keyserver/src/updaters/account-updaters.js | ||
|---|---|---|
| 228–231 ↗ | (On Diff #25921) | In subsequent diff will return and consume in updateUserAvatar to include updates in return value after updating payload |
| keyserver/src/updaters/account-updaters.js | ||
|---|---|---|
| 228 ↗ | (On Diff #25923) | I assume returning the result here is left to a subsequent diff? |
| keyserver/src/updaters/account-updaters.js | ||
|---|---|---|
| 228 ↗ | (On Diff #25923) | Yup |