Page MenuHomePhabricator
Differential D7716

[web] Add community creation button to `CommunityPicker`
ClosedPublic
Actions

Authored by atul on May 4 2023, 8:44 AM.
Tags
None
Referenced Files
F3397835: D7716.diff
Sun, Dec 1, 7:39 PM
Unknown Object (File)
Sun, Nov 17, 7:39 AM
Unknown Object (File)
Oct 28 2024, 11:27 AM
Unknown Object (File)
Oct 28 2024, 11:27 AM
Unknown Object (File)
Oct 28 2024, 11:27 AM
Unknown Object (File)
Oct 28 2024, 11:25 AM
Unknown Object (File)
Oct 2 2024, 2:40 PM
Unknown Object (File)
Sep 25 2024, 4:59 PM
View All 62 Files
Subscribers
inka
tomek

Details

Reviewers
ashoat
ginsu
inka
Commits
rCOMM7fd76c0f8546: [web] Add community creation button to `CommunityPicker`
Summary

Just adding this button and hiding it behind isCommunityCreationButtonEnabled flag.

Button doesn't do anything at the moment, in subsequent diffs will introduce modal with the community creation "wizard."

Test Plan

Looks as expected:

dc00cf.png (232×608 px, 19 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.May 4 2023, 8:44 AM
Herald added a subscriber: tomek. · View Herald TranscriptMay 4 2023, 8:44 AM
atul edited the test plan for this revision. (Show Details)May 4 2023, 8:46 AM
Harbormaster completed remote builds in B19043: Diff 26075.May 4 2023, 9:02 AM
atul requested review of this revision.May 4 2023, 9:02 AM
ashoat accepted this revision.May 4 2023, 9:51 AM
ashoat added a reviewer: inka.
ashoat added a subscriber: inka.

I believe @inka introduced CommunityPicker, so she should definitely be on the review

This revision is now accepted and ready to land.May 4 2023, 9:51 AM
atul added a comment.May 4 2023, 10:04 AM
In D7716#228907, @ashoat wrote:

I believe @inka introduced CommunityPicker, so she should definitely be on the review

Good point, I should've taken a quick look at blame instead of just defaulting to reviewers from avatar work.

Closed by commit rCOMM7fd76c0f8546: [web] Add community creation button to `CommunityPicker` (authored by atul). · Explain WhyMay 4 2023, 10:07 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM7fd76c0f8546: [web] Add community creation button to `CommunityPicker`.

Revision Contents
Changeset List

PathSize
web/
sidebar/
13 lines
15 lines
1 line

Diff 26082

View Options

web/sidebar/community-picker.css

Loading...
View Options

web/sidebar/community-picker.react.js

Loading...
View Options

web/theme.css

Loading...