Details

Reviewers

ashoat
ginsu

Commits

rCOMM6cb4c89ac6a2: [native] Memoize `roundCorners` in `community-pill`

Summary

Was looking at this component as part of CommunityCreationModal work and noticed roundCorners could be memoized.

Test Plan

Close reading.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.May 4 2023, 7:28 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 4 2023, 7:28 PM

Harbormaster completed remote builds in B19055: Diff 26089.May 4 2023, 7:48 PM

atul requested review of this revision.May 4 2023, 7:48 PM

Can we just pull this outside of the function body?

This revision is now accepted and ready to land.May 4 2023, 8:27 PM

In D7722#229022, @ashoat wrote:

Can we just pull this outside of the function body?

True, I'll just do that

rebase before addressing feedback

Harbormaster completed remote builds in B19113: Diff 26167.May 8 2023, 10:36 AM

rebase (fixing env)

address feedback

Harbormaster completed remote builds in B19135: Diff 26198.May 8 2023, 1:07 PM

Harbormaster completed remote builds in B19136: Diff 26200.May 8 2023, 1:09 PM

Closed by commit rCOMM6cb4c89ac6a2: [native] Memoize `roundCorners` in `community-pill`. · Explain WhyMay 8 2023, 2:21 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM6cb4c89ac6a2: [native] Memoize `roundCorners` in `community-pill`.

[native] Memoize `roundCorners` in `community-pill`
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 26089

native/components/community-pill.react.js

[native] Memoize `roundCorners` in `community-pill`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26089

native/components/community-pill.react.js

[native] Memoize `roundCorners` in `community-pill`
ClosedPublic
Actions

Revision Contents
Changeset List