Page MenuHomePhabricator

[native] Memoize `roundCorners` in `community-pill`
ClosedPublic

Authored by atul on May 4 2023, 12:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 2:11 AM
Unknown Object (File)
Mon, Nov 4, 5:27 PM
Unknown Object (File)
Oct 3 2024, 5:02 AM
Unknown Object (File)
Sep 29 2024, 3:32 AM
Unknown Object (File)
Sep 20 2024, 7:05 AM
Unknown Object (File)
Sep 17 2024, 11:58 PM
Unknown Object (File)
Sep 17 2024, 11:58 PM
Unknown Object (File)
Sep 17 2024, 11:58 PM
Subscribers

Details

Summary

Was looking at this component as part of CommunityCreationModal work and noticed roundCorners could be memoized.

Test Plan

Close reading.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D7722 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.May 4 2023, 12:48 PM

Can we just pull this outside of the function body?

This revision is now accepted and ready to land.May 4 2023, 1:27 PM

Can we just pull this outside of the function body?

True, I'll just do that

rebase before addressing feedback