Page MenuHomePhabricator
Differential D7722

[native] Memoize `roundCorners` in `community-pill`
ClosedPublic
Actions

Authored by atul on May 4 2023, 12:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 2:11 AM
Unknown Object (File)
Mon, Nov 4, 5:27 PM
Unknown Object (File)
Oct 3 2024, 5:02 AM
Unknown Object (File)
Sep 29 2024, 3:32 AM
Unknown Object (File)
Sep 20 2024, 7:05 AM
Unknown Object (File)
Sep 17 2024, 11:58 PM
Unknown Object (File)
Sep 17 2024, 11:58 PM
Unknown Object (File)
Sep 17 2024, 11:58 PM
View All 91 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM6cb4c89ac6a2: [native] Memoize `roundCorners` in `community-pill`
Summary

Was looking at this component as part of CommunityCreationModal work and noticed roundCorners could be memoized.

Test Plan

Close reading.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D7722_1 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.May 4 2023, 12:28 PM
Herald added a subscriber: tomek. · View Herald TranscriptMay 4 2023, 12:28 PM
Harbormaster completed remote builds in B19055: Diff 26089.May 4 2023, 12:48 PM
atul requested review of this revision.May 4 2023, 12:48 PM
ashoat accepted this revision.May 4 2023, 1:27 PM

Can we just pull this outside of the function body?

This revision is now accepted and ready to land.May 4 2023, 1:27 PM
atul added a comment.May 8 2023, 3:12 AM
In D7722#229022, @ashoat wrote:

Can we just pull this outside of the function body?

True, I'll just do that

atul updated this revision to Diff 26167.May 8 2023, 3:19 AM

rebase before addressing feedback

Harbormaster completed remote builds in B19113: Diff 26167.May 8 2023, 3:36 AM
atul updated this revision to Diff 26198.May 8 2023, 5:50 AM

rebase (fixing env)

atul updated this revision to Diff 26200.May 8 2023, 5:51 AM

address feedback

Harbormaster completed remote builds in B19135: Diff 26198.May 8 2023, 6:07 AM
Harbormaster completed remote builds in B19136: Diff 26200.May 8 2023, 6:09 AM
Closed by commit rCOMM6cb4c89ac6a2: [native] Memoize `roundCorners` in `community-pill` (authored by atul). · Explain WhyMay 8 2023, 7:21 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM6cb4c89ac6a2: [native] Memoize `roundCorners` in `community-pill`.

Revision Contents
Changeset List

PathSize
native/
components/
7 lines

Diff 26198

View Options

native/components/community-pill.react.js

Loading...