Page MenuHomePhabricator

[native] Memoize `roundCorners` in `community-pill`
ClosedPublic

Authored by atul on May 4 2023, 12:28 PM.
Tags
None
Referenced Files
F3383254: D7722.diff
Thu, Nov 28, 2:33 PM
Unknown Object (File)
Mon, Nov 11, 1:27 AM
Unknown Object (File)
Mon, Nov 11, 1:27 AM
Unknown Object (File)
Mon, Nov 11, 1:27 AM
Unknown Object (File)
Mon, Nov 11, 1:27 AM
Unknown Object (File)
Mon, Nov 11, 1:27 AM
Unknown Object (File)
Mon, Nov 11, 1:26 AM
Unknown Object (File)
Thu, Nov 7, 11:11 PM
Subscribers

Details

Summary

Was looking at this component as part of CommunityCreationModal work and noticed roundCorners could be memoized.

Test Plan

Close reading.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D7722_1 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.May 4 2023, 12:48 PM

Can we just pull this outside of the function body?

This revision is now accepted and ready to land.May 4 2023, 1:27 PM

Can we just pull this outside of the function body?

True, I'll just do that

rebase before addressing feedback