Page MenuHomePhabricator

[native] Factor out loading spinner from SIWEPanel
ClosedPublic

Authored by ashoat on May 16 2023, 6:58 AM.
Tags
None
Referenced Files
F3554225: D7841.id26542.diff
Thu, Dec 26, 9:43 PM
F3554189: D7841.id26560.diff
Thu, Dec 26, 9:42 PM
F3541716: D7841.diff
Thu, Dec 26, 7:01 AM
Unknown Object (File)
Mon, Dec 9, 10:40 PM
Unknown Object (File)
Tue, Dec 3, 10:54 PM
Unknown Object (File)
Tue, Dec 3, 10:53 PM
Unknown Object (File)
Tue, Dec 3, 10:53 PM
Unknown Object (File)
Nov 10 2024, 10:33 PM
Subscribers

Details

Summary

We want to use SIWEPanel in the new registration flow, but it currently renders a large spinner with flex: 1 while loading, which doesn't match the designs for the new registration flow.

To make SIWEPanel usable in both the old and new context, this diff factors out the spinner code into FullscreenSIWEPanel, making SIWEPanel more reusable.

Depends on D7840

Test Plan

Make sure the loading spinner still appears full-screen in the old experience

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable