Page MenuHomePhabricator

[native] Make panelSecondaryForeground light mode correspond to dark mode
ClosedPublic

Authored by ashoat on May 19 2023, 11:08 AM.
Tags
None
Referenced Files
F3385294: D7888.id26691.diff
Thu, Nov 28, 11:57 PM
F3385002: D7888.diff
Thu, Nov 28, 11:01 PM
Unknown Object (File)
Thu, Nov 28, 12:38 AM
Unknown Object (File)
Mon, Nov 25, 10:54 AM
Unknown Object (File)
Thu, Nov 14, 11:24 AM
Unknown Object (File)
Thu, Nov 14, 11:24 AM
Unknown Object (File)
Thu, Nov 14, 11:22 AM
Unknown Object (File)
Thu, Nov 14, 11:00 AM
Subscribers

Details

Summary

We're using shadesDark80 and shadesDark70 for dark mode, so I figure it made sense to use the corresponding shadesWhite80 and shadesWhite70 for light mode.

I also think this looks better. Note that panelSecondaryForeground is only used in the calendar, as well as the inner tile in ExistingEthereumAccount. Meanwhile, panelSecondaryForegroundBorder is only used for placeholder text in the new registration flow, and the border around a non-selected radio button in RegistrationTile. Screenshots for all three are in the Test Plan.

Depends on D7887

Test Plan
beforeafter
calendar (secondary foreground)
Screenshot 2023-05-19 at 2.05.07 PM.png (2×1 px, 895 KB)
Screenshot 2023-05-19 at 2.05.43 PM.png (2×1 px, 899 KB)
inner tile (secondary foreground)
Screenshot 2023-05-19 at 2.04.47 PM.png (2×1 px, 831 KB)
Screenshot 2023-05-19 at 2.04.38 PM.png (2×1 px, 831 KB)
RegistrationTile (secondary foreground border)
Screenshot 2023-05-19 at 2.18.40 PM.png (2×1 px, 867 KB)
Screenshot 2023-05-19 at 2.18.54 PM.png (2×1 px, 866 KB)

For RegistrationTile, the secondary foreground border color is used in the non-selected radio button border and the placeholder text.

Note that the registration flow will ONLY support dark mode; the screenshots are shared to give some visual context, but are not real screenshots that will be possible in the app.

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/registration
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat edited the test plan for this revision. (Show Details)
ashoat edited the test plan for this revision. (Show Details)

Cool, thank you for the screen shots to provide context!

This revision is now accepted and ready to land.May 19 2023, 11:37 AM