Page MenuHomePhabricator
Differential D7875

[native] Introduce ExistingEthereumAccount screen
ClosedPublic
Actions

Authored by ashoat on May 19 2023, 9:04 AM.
Tags
None
Referenced Files
F3367620: D7875.diff
Mon, Nov 25, 3:14 PM
Unknown Object (File)
Thu, Nov 14, 11:24 AM
Unknown Object (File)
Thu, Nov 14, 11:24 AM
Unknown Object (File)
Thu, Nov 14, 11:23 AM
Unknown Object (File)
Thu, Nov 14, 11:00 AM
Unknown Object (File)
Tue, Nov 5, 11:04 PM
Unknown Object (File)
Oct 15 2024, 2:58 AM
Unknown Object (File)
Oct 15 2024, 2:58 AM
View All 66 Files
Subscribers
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMMf633c4d64f5d: [native] Introduce ExistingEthereumAccount screen
Summary

See designs here. Actual login functionality and display of existing Ethereum account info will come in a later diff.

Depends on D7867

Test Plan
  1. I tested that if I attempted to connect an Ethereum account that already corresponded to an existing Comm account, I got sent to this new screen
  2. I made sure the "Use a different wallet" button navigated back to the previous screen (ConnectEthereum)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.May 19 2023, 9:04 AM
Herald added a subscriber: tomek. · View Herald TranscriptMay 19 2023, 9:04 AM
Harbormaster completed remote builds in B19507: Diff 26672.May 19 2023, 9:22 AM
ashoat requested review of this revision.May 19 2023, 9:22 AM
ashoat added inline comments.May 19 2023, 9:51 AM
native/account/registration/connect-ethereum.react.js
155 ↗(On Diff #26672)

Snuck this change in. I think the shorter copy is better

ashoat added a child revision: D7882: [native] Add code to log user in via ExistingEthereumAccount.May 19 2023, 10:08 AM
atul accepted this revision.May 19 2023, 11:03 AM
This revision is now accepted and ready to land.May 19 2023, 11:03 AM
Closed by commit rCOMMf633c4d64f5d: [native] Introduce ExistingEthereumAccount screen (authored by ashoat). · Explain WhyMay 19 2023, 12:56 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMf633c4d64f5d: [native] Introduce ExistingEthereumAccount screen.

Revision Contents
Changeset List

PathSize
native/
account/
registration/
16 lines
71 lines
6 lines
navigation/
3 lines

Diff 26704

View Options

native/account/registration/connect-ethereum.react.js

Loading...
View Options

native/account/registration/existing-ethereum-account.react.js

Loading...
View Options

native/account/registration/registration-navigator.react.js

Loading...
View Options

native/navigation/route-names.js

Loading...