Page MenuHomePhabricator

[native] Update panelSecondaryForeground to shadesBlack80
ClosedPublic

Authored by ashoat on May 19 2023, 10:57 AM.
Tags
None
Referenced Files
F3368392: D7887.id26707.diff
Mon, Nov 25, 7:39 PM
F3368097: D7887.diff
Mon, Nov 25, 6:09 PM
Unknown Object (File)
Thu, Nov 14, 11:25 AM
Unknown Object (File)
Thu, Nov 14, 11:25 AM
Unknown Object (File)
Thu, Nov 14, 11:23 AM
Unknown Object (File)
Thu, Nov 14, 11:00 AM
Unknown Object (File)
Oct 22 2024, 10:28 PM
Unknown Object (File)
Oct 22 2024, 2:46 PM
Subscribers

Details

Summary

In the previous diff, I was implementing a design where the walletIdentifierTile (panel foreground) had a tile inside it. I figured that inner tile should logically use the "panel secondary foreground" color.

However, panelSecondaryForeground was currently set to #333333, which does not appear in our design system, and did not match the designs for the inner tile.

This diff updates panelSecondaryForeground to match the designs for the inner tile, and makes sure it's now using a color from the design system. The only other place that is impacted is the calendar tab.

Test Plan
beforeafter
registration
Screenshot 2023-05-19 at 1.51.43 PM.png (2×1 px, 830 KB)
Screenshot 2023-05-19 at 1.52.56 PM.png (2×1 px, 831 KB)
calendar
Screenshot 2023-05-19 at 1.54.07 PM.png (2×1 px, 899 KB)
Screenshot 2023-05-19 at 1.53.33 PM.png (2×1 px, 896 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable