Page MenuHomePhabricator
Differential D7897

Update &apos to &rsquo
ClosedPublic
Actions

Authored by ashoat on May 20 2023, 5:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 2:19 AM
Unknown Object (File)
Sun, Mar 30, 3:01 AM
Unknown Object (File)
Wed, Mar 19, 9:58 PM
Unknown Object (File)
Mon, Mar 17, 6:43 PM
Unknown Object (File)
Thu, Mar 6, 12:25 PM
Unknown Object (File)
Thu, Mar 6, 12:25 PM
Unknown Object (File)
Thu, Mar 6, 12:25 PM
Unknown Object (File)
Wed, Mar 5, 12:57 PM
View All 100 Files
Subscribers
atul
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMM07a58f582044: Update &apos to &rsquo
Summary

In D7893, @atul pointed out that &apos is actually the ASCII single-quote character ('), while &rsquo is the Unicode character preferred for apostrophes. I did some Googling and found this resource, which supports the idea that the right-side quote character is the preferred Unicode character for apostrophe usage.

Test Plan

I made sure that the character looked better on one of the screens (ConnectEthereum). For the rest, I'm relying on careful reading

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/registration
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

Diff 26722

View Options

landing/keyservers.react.js

  • This file was added.
syntax = "proto3";
package identity.client;
// RPCs from a client (iOS, Android, or web) to identity service
service IdentityClientService {
// Called by user to register with the Identity Service (PAKE only)
rpc RegisterUser(stream RegistrationRequest) returns (stream
RegistrationResponse) {}
// Called by user to update password and receive new access token
rpc UpdateUserPassword(stream UpdateUserPasswordRequest) returns
(stream UpdateUserPasswordResponse) {}
// Called by user to register device and get an access token
rpc LoginPasswordUser(stream OpaqueLoginRequest) returns
(stream OpaqueLoginResponse) {}
rpc LoginWalletUser(WalletLoginRequest) returns (WalletLoginResponse) {}
// Called by a user to delete their own account
rpc DeleteUser(DeleteUserRequest) returns (Empty) {}
// Called by clients to get a nonce for a Sign-In with Ethereum message
rpc GenerateNonce(Empty) returns (GenerateNonceResponse) {}
// Called by clients to get session initialization info needed to open a new
// channel of communication with a given user
rpc GetSessionInitializationInfo(GetSessionInitializationInfoRequest) returns
(GetSessionInitializationInfoResponse) {}
}
// Helper types
message Empty {}
message SessionInitializationInfo {
string payload = 1;
string payloadSignature = 2; // payload signed with the signing ed25519 key
optional string socialProof = 3; // signed message used for SIWE (optional)
}
// RegisterUser
// Request for registering a new user
message ClientRegistrationRequest {
// ed25519 key for the given user's device
string deviceEd25519PublicKey = 1;
// Message sent to initiate PAKE registration (step 1)
bytes opaqueRegistrationRequest = 2;
string username = 3;
// Information specific to a user's device needed to open a new channel of
// communication with this user
SessionInitializationInfo sessionInitializationInfo = 4;
}
// Messages sent from a client to Identity Service
message RegistrationRequest {
oneof data {
// First message in PAKE registration + user information
ClientRegistrationRequest registrationRequest = 1;
// Final message in PAKE registration
bytes opaqueRegistrationUpload = 2;
}
}
// Messages sent from Identity Service to client
message RegistrationResponse {
oneof data {
// sent to the user upon reception of the PAKE registration attempt
// (step 2)
bytes opaqueRegistrationResponse = 1;
// After successful unpacking of user credentials, return token
string accessToken = 2;
}
}
// UpdateUserPassword
// Request for updating a user, similar to registration but need a
// access token to validate user before updating password
message InitialUpdateUserPasswordRequest {
// ed25519 key for the given user's device
string signingPublicKey = 1;
// Message sent to initiate PAKE registration (step 1)
bytes opaqueRegistrationRequest = 2;
string username = 3;
// Information specific to a user's device needed to open a new channel of
// communication with this user
SessionInitializationInfo sessionInitializationInfo = 4;
// Used to validate user, before attempting to update password
string accessToken = 5;
}
// Do a user registration, but overwrite the existing credentials
// after validation of user
message UpdateUserPasswordRequest {
oneof data {
InitialUpdateUserPasswordRequest updateRequest = 1;
bytes opaqueRegistrationUpload = 2;
}
}
message UpdateUserPasswordResponse {
oneof data {
bytes opaqueRegistrationResponse = 1;
// After validating client reponse, mint a new token
string accessToken = 2;
}
}
// LoginUser
message InitialOpaqueLoginRequest {
string username = 1;
// ed25519 key for the given user's device
string signingPublicKey = 2;
// Message sent to initiate PAKE login (step 1)
bytes opaqueLoginRequest = 3;
// Information specific to a user's device needed to open a new channel of
// communication with this user
SessionInitializationInfo sessionInitializationInfo = 4;
}
message OpaqueLoginRequest {
oneof data {
InitialOpaqueLoginRequest loginRequest = 1;
// Message containing client's reponse to server challenge.
// Used to verify that client holds password secret (Step 3)
bytes opaqueLoginUpload = 1;
}
}
message OpaqueLoginResponse {
oneof data {
// Opaque challenge sent from server to client attempting to login (Step 2)
bytes opaqueServerResponse = 1;
// Mint and return a new key upon successful login
string accessToken = 2;
}
}
message WalletLoginRequest {
// ed25519 key for the given user's device
string signingPublicKey = 1;
string siweMessage = 2;
string siweSignature = 3;
// Information specific to a user's device needed to open a new channel of
// communication with this user
SessionInitializationInfo sessionInitializationInfo = 4;
}
message WalletLoginResponse {
string accessToken = 1;
}
// DeleteUser
message DeleteUserRequest {
string accessToken = 1;
}
// GenerateNonce
message GenerateNonceResponse{
string nonce = 1;
}
// GetSessionInitializationInfo
message GetSessionInitializationInfoRequest {
oneof identifier {
string username = 1;
string walletAddress = 2;
}
}
message GetSessionInitializationInfoResponse {
// Map is keyed on devices' public ed25519 key used for signing
map<string, SessionInitializationInfo> devices = 1;
}
View Options

landing/privacy.react.js

  • This file was added.
syntax = "proto3";
package identity.client;
// RPCs from a client (iOS, Android, or web) to identity service
service IdentityClientService {
// Called by user to register with the Identity Service (PAKE only)
rpc RegisterUser(stream RegistrationRequest) returns (stream
RegistrationResponse) {}
// Called by user to update password and receive new access token
rpc UpdateUserPassword(stream UpdateUserPasswordRequest) returns
(stream UpdateUserPasswordResponse) {}
// Called by user to register device and get an access token
rpc LoginPasswordUser(stream OpaqueLoginRequest) returns
(stream OpaqueLoginResponse) {}
rpc LoginWalletUser(WalletLoginRequest) returns (WalletLoginResponse) {}
// Called by a user to delete their own account
rpc DeleteUser(DeleteUserRequest) returns (Empty) {}
// Called by clients to get a nonce for a Sign-In with Ethereum message
rpc GenerateNonce(Empty) returns (GenerateNonceResponse) {}
// Called by clients to get session initialization info needed to open a new
// channel of communication with a given user
rpc GetSessionInitializationInfo(GetSessionInitializationInfoRequest) returns
(GetSessionInitializationInfoResponse) {}
}
// Helper types
message Empty {}
message SessionInitializationInfo {
string payload = 1;
string payloadSignature = 2; // payload signed with the signing ed25519 key
optional string socialProof = 3; // signed message used for SIWE (optional)
}
// RegisterUser
// Request for registering a new user
message ClientRegistrationRequest {
// ed25519 key for the given user's device
string deviceEd25519PublicKey = 1;
// Message sent to initiate PAKE registration (step 1)
bytes opaqueRegistrationRequest = 2;
string username = 3;
// Information specific to a user's device needed to open a new channel of
// communication with this user
SessionInitializationInfo sessionInitializationInfo = 4;
}
// Messages sent from a client to Identity Service
message RegistrationRequest {
oneof data {
// First message in PAKE registration + user information
ClientRegistrationRequest registrationRequest = 1;
// Final message in PAKE registration
bytes opaqueRegistrationUpload = 2;
}
}
// Messages sent from Identity Service to client
message RegistrationResponse {
oneof data {
// sent to the user upon reception of the PAKE registration attempt
// (step 2)
bytes opaqueRegistrationResponse = 1;
// After successful unpacking of user credentials, return token
string accessToken = 2;
}
}
// UpdateUserPassword
// Request for updating a user, similar to registration but need a
// access token to validate user before updating password
message InitialUpdateUserPasswordRequest {
// ed25519 key for the given user's device
string signingPublicKey = 1;
// Message sent to initiate PAKE registration (step 1)
bytes opaqueRegistrationRequest = 2;
string username = 3;
// Information specific to a user's device needed to open a new channel of
// communication with this user
SessionInitializationInfo sessionInitializationInfo = 4;
// Used to validate user, before attempting to update password
string accessToken = 5;
}
// Do a user registration, but overwrite the existing credentials
// after validation of user
message UpdateUserPasswordRequest {
oneof data {
InitialUpdateUserPasswordRequest updateRequest = 1;
bytes opaqueRegistrationUpload = 2;
}
}
message UpdateUserPasswordResponse {
oneof data {
bytes opaqueRegistrationResponse = 1;
// After validating client reponse, mint a new token
string accessToken = 2;
}
}
// LoginUser
message InitialOpaqueLoginRequest {
string username = 1;
// ed25519 key for the given user's device
string signingPublicKey = 2;
// Message sent to initiate PAKE login (step 1)
bytes opaqueLoginRequest = 3;
// Information specific to a user's device needed to open a new channel of
// communication with this user
SessionInitializationInfo sessionInitializationInfo = 4;
}
message OpaqueLoginRequest {
oneof data {
InitialOpaqueLoginRequest loginRequest = 1;
// Message containing client's reponse to server challenge.
// Used to verify that client holds password secret (Step 3)
bytes opaqueLoginUpload = 1;
}
}
message OpaqueLoginResponse {
oneof data {
// Opaque challenge sent from server to client attempting to login (Step 2)
bytes opaqueServerResponse = 1;
// Mint and return a new key upon successful login
string accessToken = 2;
}
}
message WalletLoginRequest {
// ed25519 key for the given user's device
string signingPublicKey = 1;
string siweMessage = 2;
string siweSignature = 3;
// Information specific to a user's device needed to open a new channel of
// communication with this user
SessionInitializationInfo sessionInitializationInfo = 4;
}
message WalletLoginResponse {
string accessToken = 1;
}
// DeleteUser
message DeleteUserRequest {
string accessToken = 1;
}
// GenerateNonce
message GenerateNonceResponse{
string nonce = 1;
}
// GetSessionInitializationInfo
message GetSessionInitializationInfoRequest {
oneof identifier {
string username = 1;
string walletAddress = 2;
}
}
message GetSessionInitializationInfoResponse {
// Map is keyed on devices' public ed25519 key used for signing
map<string, SessionInitializationInfo> devices = 1;
}
View Options

landing/qr.react.js

  • This file was added.
syntax = "proto3";
package identity.client;
// RPCs from a client (iOS, Android, or web) to identity service
service IdentityClientService {
// Called by user to register with the Identity Service (PAKE only)
rpc RegisterUser(stream RegistrationRequest) returns (stream
RegistrationResponse) {}
// Called by user to update password and receive new access token
rpc UpdateUserPassword(stream UpdateUserPasswordRequest) returns
(stream UpdateUserPasswordResponse) {}
// Called by user to register device and get an access token
rpc LoginPasswordUser(stream OpaqueLoginRequest) returns
(stream OpaqueLoginResponse) {}
rpc LoginWalletUser(WalletLoginRequest) returns (WalletLoginResponse) {}
// Called by a user to delete their own account
rpc DeleteUser(DeleteUserRequest) returns (Empty) {}
// Called by clients to get a nonce for a Sign-In with Ethereum message
rpc GenerateNonce(Empty) returns (GenerateNonceResponse) {}
// Called by clients to get session initialization info needed to open a new
// channel of communication with a given user
rpc GetSessionInitializationInfo(GetSessionInitializationInfoRequest) returns
(GetSessionInitializationInfoResponse) {}
}
// Helper types
message Empty {}
message SessionInitializationInfo {
string payload = 1;
string payloadSignature = 2; // payload signed with the signing ed25519 key
optional string socialProof = 3; // signed message used for SIWE (optional)
}
// RegisterUser
// Request for registering a new user
message ClientRegistrationRequest {
// ed25519 key for the given user's device
string deviceEd25519PublicKey = 1;
// Message sent to initiate PAKE registration (step 1)
bytes opaqueRegistrationRequest = 2;
string username = 3;
// Information specific to a user's device needed to open a new channel of
// communication with this user
SessionInitializationInfo sessionInitializationInfo = 4;
}
// Messages sent from a client to Identity Service
message RegistrationRequest {
oneof data {
// First message in PAKE registration + user information
ClientRegistrationRequest registrationRequest = 1;
// Final message in PAKE registration
bytes opaqueRegistrationUpload = 2;
}
}
// Messages sent from Identity Service to client
message RegistrationResponse {
oneof data {
// sent to the user upon reception of the PAKE registration attempt
// (step 2)
bytes opaqueRegistrationResponse = 1;
// After successful unpacking of user credentials, return token
string accessToken = 2;
}
}
// UpdateUserPassword
// Request for updating a user, similar to registration but need a
// access token to validate user before updating password
message InitialUpdateUserPasswordRequest {
// ed25519 key for the given user's device
string signingPublicKey = 1;
// Message sent to initiate PAKE registration (step 1)
bytes opaqueRegistrationRequest = 2;
string username = 3;
// Information specific to a user's device needed to open a new channel of
// communication with this user
SessionInitializationInfo sessionInitializationInfo = 4;
// Used to validate user, before attempting to update password
string accessToken = 5;
}
// Do a user registration, but overwrite the existing credentials
// after validation of user
message UpdateUserPasswordRequest {
oneof data {
InitialUpdateUserPasswordRequest updateRequest = 1;
bytes opaqueRegistrationUpload = 2;
}
}
message UpdateUserPasswordResponse {
oneof data {
bytes opaqueRegistrationResponse = 1;
// After validating client reponse, mint a new token
string accessToken = 2;
}
}
// LoginUser
message InitialOpaqueLoginRequest {
string username = 1;
// ed25519 key for the given user's device
string signingPublicKey = 2;
// Message sent to initiate PAKE login (step 1)
bytes opaqueLoginRequest = 3;
// Information specific to a user's device needed to open a new channel of
// communication with this user
SessionInitializationInfo sessionInitializationInfo = 4;
}
message OpaqueLoginRequest {
oneof data {
InitialOpaqueLoginRequest loginRequest = 1;
// Message containing client's reponse to server challenge.
// Used to verify that client holds password secret (Step 3)
bytes opaqueLoginUpload = 1;
}
}
message OpaqueLoginResponse {
oneof data {
// Opaque challenge sent from server to client attempting to login (Step 2)
bytes opaqueServerResponse = 1;
// Mint and return a new key upon successful login
string accessToken = 2;
}
}
message WalletLoginRequest {
// ed25519 key for the given user's device
string signingPublicKey = 1;
string siweMessage = 2;
string siweSignature = 3;
// Information specific to a user's device needed to open a new channel of
// communication with this user
SessionInitializationInfo sessionInitializationInfo = 4;
}
message WalletLoginResponse {
string accessToken = 1;
}
// DeleteUser
message DeleteUserRequest {
string accessToken = 1;
}
// GenerateNonce
message GenerateNonceResponse{
string nonce = 1;
}
// GetSessionInitializationInfo
message GetSessionInitializationInfoRequest {
oneof identifier {
string username = 1;
string walletAddress = 2;
}
}
message GetSessionInitializationInfoResponse {
// Map is keyed on devices' public ed25519 key used for signing
map<string, SessionInitializationInfo> devices = 1;
}
View Options

landing/terms.react.js

  • This file was added.
syntax = "proto3";
package identity.client;
// RPCs from a client (iOS, Android, or web) to identity service
service IdentityClientService {
// Called by user to register with the Identity Service (PAKE only)
rpc RegisterUser(stream RegistrationRequest) returns (stream
RegistrationResponse) {}
// Called by user to update password and receive new access token
rpc UpdateUserPassword(stream UpdateUserPasswordRequest) returns
(stream UpdateUserPasswordResponse) {}
// Called by user to register device and get an access token
rpc LoginPasswordUser(stream OpaqueLoginRequest) returns
(stream OpaqueLoginResponse) {}
rpc LoginWalletUser(WalletLoginRequest) returns (WalletLoginResponse) {}
// Called by a user to delete their own account
rpc DeleteUser(DeleteUserRequest) returns (Empty) {}
// Called by clients to get a nonce for a Sign-In with Ethereum message
rpc GenerateNonce(Empty) returns (GenerateNonceResponse) {}
// Called by clients to get session initialization info needed to open a new
// channel of communication with a given user
rpc GetSessionInitializationInfo(GetSessionInitializationInfoRequest) returns
(GetSessionInitializationInfoResponse) {}
}
// Helper types
message Empty {}
message SessionInitializationInfo {
string payload = 1;
string payloadSignature = 2; // payload signed with the signing ed25519 key
optional string socialProof = 3; // signed message used for SIWE (optional)
}
// RegisterUser
// Request for registering a new user
message ClientRegistrationRequest {
// ed25519 key for the given user's device
string deviceEd25519PublicKey = 1;
// Message sent to initiate PAKE registration (step 1)
bytes opaqueRegistrationRequest = 2;
string username = 3;
// Information specific to a user's device needed to open a new channel of
// communication with this user
SessionInitializationInfo sessionInitializationInfo = 4;
}
// Messages sent from a client to Identity Service
message RegistrationRequest {
oneof data {
// First message in PAKE registration + user information
ClientRegistrationRequest registrationRequest = 1;
// Final message in PAKE registration
bytes opaqueRegistrationUpload = 2;
}
}
// Messages sent from Identity Service to client
message RegistrationResponse {
oneof data {
// sent to the user upon reception of the PAKE registration attempt
// (step 2)
bytes opaqueRegistrationResponse = 1;
// After successful unpacking of user credentials, return token
string accessToken = 2;
}
}
// UpdateUserPassword
// Request for updating a user, similar to registration but need a
// access token to validate user before updating password
message InitialUpdateUserPasswordRequest {
// ed25519 key for the given user's device
string signingPublicKey = 1;
// Message sent to initiate PAKE registration (step 1)
bytes opaqueRegistrationRequest = 2;
string username = 3;
// Information specific to a user's device needed to open a new channel of
// communication with this user
SessionInitializationInfo sessionInitializationInfo = 4;
// Used to validate user, before attempting to update password
string accessToken = 5;
}
// Do a user registration, but overwrite the existing credentials
// after validation of user
message UpdateUserPasswordRequest {
oneof data {
InitialUpdateUserPasswordRequest updateRequest = 1;
bytes opaqueRegistrationUpload = 2;
}
}
message UpdateUserPasswordResponse {
oneof data {
bytes opaqueRegistrationResponse = 1;
// After validating client reponse, mint a new token
string accessToken = 2;
}
}
// LoginUser
message InitialOpaqueLoginRequest {
string username = 1;
// ed25519 key for the given user's device
string signingPublicKey = 2;
// Message sent to initiate PAKE login (step 1)
bytes opaqueLoginRequest = 3;
// Information specific to a user's device needed to open a new channel of
// communication with this user
SessionInitializationInfo sessionInitializationInfo = 4;
}
message OpaqueLoginRequest {
oneof data {
InitialOpaqueLoginRequest loginRequest = 1;
// Message containing client's reponse to server challenge.
// Used to verify that client holds password secret (Step 3)
bytes opaqueLoginUpload = 1;
}
}
message OpaqueLoginResponse {
oneof data {
// Opaque challenge sent from server to client attempting to login (Step 2)
bytes opaqueServerResponse = 1;
// Mint and return a new key upon successful login
string accessToken = 2;
}
}
message WalletLoginRequest {
// ed25519 key for the given user's device
string signingPublicKey = 1;
string siweMessage = 2;
string siweSignature = 3;
// Information specific to a user's device needed to open a new channel of
// communication with this user
SessionInitializationInfo sessionInitializationInfo = 4;
}
message WalletLoginResponse {
string accessToken = 1;
}
// DeleteUser
message DeleteUserRequest {
string accessToken = 1;
}
// GenerateNonce
message GenerateNonceResponse{
string nonce = 1;
}
// GetSessionInitializationInfo
message GetSessionInitializationInfoRequest {
oneof identifier {
string username = 1;
string walletAddress = 2;
}
}
message GetSessionInitializationInfoResponse {
// Map is keyed on devices' public ed25519 key used for signing
map<string, SessionInitializationInfo> devices = 1;
}
View Options

native/account/registration/connect-ethereum.react.js

Loading...
View Options

native/account/terms-and-privacy-modal.react.js

Loading...
View Options

native/chat/chat-input-bar.react.js

Loading...
View Options

native/crash.react.js

Loading...
View Options

web/chat/chat-input-bar.react.js

Loading...
View Options

web/modals/chat/invalid-upload.react.js

Loading...
View Options

web/modals/terms-and-privacy-modal.react.js

Loading...