Page MenuHomePhabricator
Differential D7976

[native] Use BlobUtils for media encryption/decryption
ClosedPublic
Actions

Authored by bartek on May 25 2023, 7:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 9, 9:15 AM
Unknown Object (File)
Sat, Mar 1, 11:52 PM
Unknown Object (File)
Fri, Feb 28, 3:44 PM
Unknown Object (File)
Fri, Feb 28, 3:44 PM
Unknown Object (File)
Fri, Feb 28, 3:44 PM
Unknown Object (File)
Fri, Feb 28, 3:44 PM
Unknown Object (File)
Thu, Feb 27, 3:26 PM
Unknown Object (File)
Wed, Feb 26, 9:27 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
marcin
Commits
rCOMM0cbe6716f620: [native] Use BlobUtils for media encryption/decryption
Summary

This diff increases the performance of media encryption/decryption by using newly introduced methods instead
of basing on response.arrayBuffer() which uses slow base64 under the hood. Details are described in parent diffs and
in the task issue.

Depends on D7974

Test Plan

Ensured that media encryption/decryption still works as expected.
For these more curious, you can check performance using the following:

const startTime = Date.now();
// code from this diff here
console.log('Time:', Date.now() - startTime);

In my case, the time went down from hundreds of milliseconds to 1-2ms.

Diff Detail

Repository
rCOMM Comm
Branch
barthap/native-perf2
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
media/
9 lines

Diff 27055

View Options

native/media/encryption-utils.js

Show First 20 Lines • Show All 367 Lines • ▼ Show 20 Lines) {
return threadMembersWithoutAddedAdmin(threadInfo).length > 2; return threadMembersWithoutAddedAdmin(threadInfo).length > 2;
} }
function threadIsPending(threadID: ?string): boolean { function threadIsPending(threadID: ?string): boolean {
return !!threadID?.startsWith('pending'); return !!threadID?.startsWith('pending');
} }
function threadIsPendingSidebar(threadID: ?string): boolean { function threadIsPendingSidebar(threadID: ?string): boolean {
return !!threadID?.startsWith('pending/sidebar/'); return (
!!threadID?.startsWith('pending/sidebar/') ||
!!threadID?.startsWith('pending/dm_sidebar')
tomekUnsubmitted
Not Done
Inline Actions

Can we extract sidebar and dm_sidebar somewhere as constants?

tomek: Can we extract `sidebar` and `dm_sidebar` somewhere as constants?
);
} }
function getSingleOtherUser( function getSingleOtherUser(
threadInfo: LegacyRawThreadInfo | RawThreadInfo | ThreadInfo, threadInfo: LegacyRawThreadInfo | RawThreadInfo | ThreadInfo,
viewerID: ?string, viewerID: ?string,
): ?string { ): ?string {
if (!viewerID) { if (!viewerID) {
return undefined; return undefined;
▲ Show 20 Lines • Show All 1,407 Lines • Show Last 20 Lines