[native] Add `CommunityCreationKeyserverLabel` to `CommunityCreationMembers`
ClosedPublic
Actions

Authored by atul on May 25 2023, 12:15 PM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMM5510d4a0d2b7: [native] Add `CommunityCreationKeyserverLabel` to `CommunityCreationMembers`

Summary

Pretty straightforward, just adding keyserver label to "Add members" screen as in the designs.

Depends on D7988

Test Plan

Looks as expected:

Simulator Screenshot - Fresh iPhone 13 Pro - 2023-05-25 at 15.16.03.png (2×1 px, 80 KB)

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.May 25 2023, 12:15 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 25 2023, 12:15 PM

atul published this revision for review.May 25 2023, 12:16 PM

atul edited the test plan for this revision. (Show Details)

atul added reviewers: ashoat, ginsu.

Harbormaster completed remote builds in B19784: Diff 27077.May 25 2023, 12:35 PM

ashoat accepted this revision.May 26 2023, 10:30 AM

This revision is now accepted and ready to land.May 26 2023, 10:30 AM

Closed by commit rCOMM5510d4a0d2b7: [native] Add `CommunityCreationKeyserverLabel` to `CommunityCreationMembers` (authored by atul). · Explain WhyMay 26 2023, 10:34 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM5510d4a0d2b7: [native] Add `CommunityCreationKeyserverLabel` to `CommunityCreationMembers`.

Revision Contents
Changeset List

Path

Size

native/

community-creation/

community-creation-members.react.js

20 lines

Diff 27077

View Options

native/community-creation/community-creation-members.react.js

Show First 20 Lines • Show All 69 Lines • ▼ Show 20 Lines	switch (this->state) {
case State::DATA_CHUNKS: {		case State::DATA_CHUNKS: {
// TODO initialize blob client reactor		// TODO initialize blob client reactor
if (ServiceBlobClient::getInstance().putReactor == nullptr) {		if (ServiceBlobClient::getInstance().putReactor == nullptr) {
throw std::runtime_error(		throw std::runtime_error(
"blob client reactor has not been initialized");		"blob client reactor has not been initialized");
}		}

ServiceBlobClient::getInstance().putReactor->scheduleSendingDataChunk(		ServiceBlobClient::getInstance().putReactor->scheduleSendingDataChunk(
request.newcompactionchunk());		std::make_unique<std::string>(
		std::move(*request.mutable_newcompactionchunk())));

return nullptr;		return nullptr;
}		}
}		}
throw std::runtime_error("new backup - invalid state");		throw std::runtime_error("new backup - invalid state");
}		}

void CreateNewBackupReactor::doneCallback() {		void CreateNewBackupReactor::doneCallback() {
ServiceBlobClient::getInstance().putReactor->scheduleSendingDataChunk("");		ServiceBlobClient::getInstance().putReactor->scheduleSendingDataChunk(
		std::make_unique<std::string>(""));
}		}

} // namespace reactor		} // namespace reactor
} // namespace network		} // namespace network
} // namespace comm		} // namespace comm

[native] Add `CommunityCreationKeyserverLabel` to `CommunityCreationMembers`ClosedPublicActions