Have the enumCheckBox in CommunityConfiguration toggle announcementSetting when tapped.
Depends on D7967
Details
Details
Looks as expected:
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Requesting changes for design iteration. Really wish this was captured in the designs we got from @ted before the hand-off
| native/community-creation/community-configuration.react.js | ||
|---|---|---|
| 191–196 ↗ | (On Diff #27015) | I can't find designs on Figma for what the box is supposed to look like checked. @atul, do you have any? If not, we should really talk to Ted about this... the placeholder text color was also missing, and all-in-all this amounts to designs that were not sufficiently fleshed out before being handed off to eng. Given he's out right now, we'll have to make a call on our own. My view is that the margin should be increased (so decrease height / width), and the borderRadius should be adjusted to match the ratio of enumCheckBoxFill to enumCheckBox size. Can you show me what height: 20, width: 20, borderRadius: 2.1875 looks like? |
| 195 ↗ | (On Diff #27015) | This color looks too dark in light mode in my opinion... it's kind of distracting. It seems like we have two light mode issues now: panelSecondaryForegroundBorder and panelForegroundSecondaryLabel, right? We should probably create a separate task under DES-71 for @ted to concretely investigate those colors and see can simply be updated to more appropriate values without degrading the experience wherever else they're being used today. |
| native/community-creation/community-configuration.react.js | ||
|---|---|---|
| 191–196 ↗ | (On Diff #27015) | I based it off of what we have on web:  Realizing that in my implementation on native I'm "filling up" more of the checkbox than we are on native. I'll adjust that.
Will do |
| native/community-creation/community-configuration.react.js | ||
|---|---|---|
| 191–196 ↗ | (On Diff #27015) | Here's how it looks:  |
| native/community-creation/community-configuration.react.js | ||
|---|---|---|
| 195 ↗ | (On Diff #27015) | Done |
Do we really need one-offs here? Why can't we find an existing color family that works with our designs?
We need to push the team (@tedchang in particular) to use existing families (and update them as necessary) instead of hacking around inconsistencies like this. When we take this sort of approach of picking colors on a per-screen basis, we fail to maintain stylistic / design consistency throughout the app