Page MenuHomePhabricator

[native] Introduce `CommunityCreationContentContainer` component
ClosedPublic

Authored by atul on Jun 1 2023, 1:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 11:38 PM
Unknown Object (File)
Sat, Dec 21, 3:50 AM
Unknown Object (File)
Fri, Dec 20, 7:38 PM
Unknown Object (File)
Thu, Dec 19, 1:57 AM
Unknown Object (File)
Thu, Dec 19, 1:36 AM
Unknown Object (File)
Thu, Dec 19, 12:48 AM
Unknown Object (File)
Sun, Dec 15, 1:56 AM
Unknown Object (File)
Oct 28 2024, 1:56 PM
Subscribers

Details

Summary

This component was heavily inspired by RegistrationContentContainer.

Replaced the ScrollView in RegistrationContentContainer with a View to avoid issue with virtualized list being nested within ScrollView:

Simulator Screenshot - Fresh iPhone 13 Pro - 2023-06-01 at 15.41.20.png (2×1 px, 271 KB)

Kept all the other styling and whatnot for consistency.

As with RegistrationContentContainer, this component can probably be made more general, "added to the design system," and moved to /components in the future. Will discuss how to approach this w/ @ted when he's back.


Depends on D8056

Test Plan

Things look as they did before and the RedBox no longer appears when the screen renders.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D8057 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.Jun 1 2023, 1:35 PM
ashoat added inline comments.
native/community-creation/community-creation-content-container.react.js
10–13 ↗(On Diff #27370)

Doesn't ViewProps already have children? I guess I did the same thing, but not clear to me if it's necessary

24–25 ↗(On Diff #27370)

Can these two components be merged? KeyboardAvoidingView already forwards ViewProps... if you apply backgroundStyle and {...rest} there, does it render the same way?

This revision is now accepted and ready to land.Jun 1 2023, 1:41 PM

rebase before addressing feedback

addressed feedback

native/community-creation/community-creation-content-container.react.js
10–13 ↗(On Diff #27370)

Doesn't ViewProps already have children?

I was wondering about that, but just ended up copying RegistrationContentContainer without investigating. Just tested and looks like we can exclude children.

24–25 ↗(On Diff #27370)

Yeah looks like it does, thanks for pointing that out. Updated.

This revision was landed with ongoing or failed builds.Jun 2 2023, 9:20 AM
This revision was automatically updated to reflect the committed changes.