[native] Rename accountSelections to accountSelection
ClosedPublic
Actions

Authored by ashoat on Jun 4 2023, 5:07 PM.

Details

Reviewers

atul
ginsu

Commits

rCOMMfb4cfe1c45fb: [native] Rename accountSelections to accountSelection

Summary

Really minor diff. This matches the name of the type introduced in the last diff (D8088) a little better, and I think is a clearer name for this.

Depneds on D8088

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jun 4 2023, 5:07 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 4 2023, 5:07 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 4 2023, 5:18 PM

Harbormaster failed remote builds in B20010: Diff 27427!

ashoat added a parent revision: D8088: [native] Move some types from avatar-selection.react.js to registration-types.js.Jun 4 2023, 9:41 PM

Rebase

Harbormaster completed remote builds in B20013: Diff 27430.Jun 4 2023, 10:01 PM

ashoat requested review of this revision.Jun 4 2023, 10:01 PM

atul accepted this revision.Jun 5 2023, 2:36 PM

This revision is now accepted and ready to land.Jun 5 2023, 2:36 PM

Closed by commit rCOMMfb4cfe1c45fb: [native] Rename accountSelections to accountSelection. · Explain WhyJun 6 2023, 3:18 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMfb4cfe1c45fb: [native] Rename accountSelections to accountSelection.

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

avatar-selection.react.js

14 lines

connect-ethereum.react.js

2 lines

password-selection.react.js

2 lines

Diff 27427

View Options

native/account/registration/avatar-selection.react.js

View Options

native/account/registration/connect-ethereum.react.js

View Options

native/account/registration/password-selection.react.js

[native] Rename accountSelections to accountSelectionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27427

native/account/registration/avatar-selection.react.js

native/account/registration/connect-ethereum.react.js

native/account/registration/password-selection.react.js

[native] Rename accountSelections to accountSelection
ClosedPublic
Actions

Revision Contents
Changeset List