[Protos] Use outbound key bundle for keyserver information
ClosedPublic
Actions

Authored by • jon on Jun 4 2023, 4:49 PM.

Details

Reviewers

ashoat
bartek
varun

Commits

rCOMM2e75c1a01b1b: [Protos] Use outbound key bundle for keyserver information

Summary

Keyserver makes use of both content and notif keys. Unify the values
to match in both cases.

The keyserver endpoint is going to remain, since it differs from
GetOutboundKeysForUser by only selecting the keyserver.

Part of https://linear.app/comm/issue/ENG-3941

Test Plan

N/A, the endpoint hasn't been implemented. This is more about design

Diff Detail

Repository

rCOMM Comm

Branch

jonringer/outboundkeys-rename

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Jun 4 2023, 4:49 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 4 2023, 4:49 PM

Harbormaster completed remote builds in B20014: Diff 27431.Jun 4 2023, 5:07 PM

• jon requested review of this revision.Jun 4 2023, 5:07 PM

ashoat accepted this revision.Jun 5 2023, 5:07 AM

This revision is now accepted and ready to land.Jun 5 2023, 5:07 AM

Closed by commit rCOMM2e75c1a01b1b: [Protos] Use outbound key bundle for keyserver information (authored by • jon). · Explain WhyJun 6 2023, 10:51 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM2e75c1a01b1b: [Protos] Use outbound key bundle for keyserver information.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

12 lines

shared/

protos/

identity_client.proto

28 lines

Diff 27431

View Options

services/identity/src/client_service.rs