Page MenuHomePhabricator
Differential D8051

[web] Fix preloading blob service URIs
ClosedPublic
Actions

Authored by bartek on Jun 1 2023, 12:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 5, 8:23 PM
Unknown Object (File)
Tue, Mar 11, 5:17 PM
Unknown Object (File)
Mar 9 2025, 7:41 PM
Unknown Object (File)
Mar 9 2025, 7:41 PM
Unknown Object (File)
Mar 9 2025, 7:41 PM
Unknown Object (File)
Mar 9 2025, 7:41 PM
Unknown Object (File)
Mar 9 2025, 7:35 PM
Unknown Object (File)
Mar 7 2025, 2:18 AM
View All 99 Files
Subscribers
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMM38c13bfdbe53: [web] Fix preloading blob service URIs
Summary

I realized that the preloadImage and preloadMediaResource functions do not resolve Blob service URIs so preloading them would fail. This diff fixes that.

Depends on D8050

Test Plan

Called preloadMediaResource with a blob-service://XXXX URI, observed the devtools Network tab.
Before it failed with network error, now it succeeds: the request is sent to https://blob.commtechnologies.org/XXXX

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
web/
media/
11 lines

Diff 27436

View Options

web/media/media-utils.js

Show All 13 Linesdiv.inlineSidebarName {
color: #666666; color: #666666;
font-size: 16px; font-size: 16px;
padding-left: 4px; padding-left: 4px;
padding-right: 2px; padding-right: 2px;
} }
div.unread { div.unread {
font-weight: bold; font-weight: bold;
} }
div.centerContainer {
justify-content: center;
}
div.nonViewerMessageBoxContainer {
justify-content: flex-start;
}
div.viewerMessageBoxContainer {
justify-content: flex-end;
}
svg.inlineSidebarIcon {
color: #666666;
}