Page MenuHomePhabricator
Differential D8087

[native] Fix userInfo calculation in UserAvatar
ClosedPublic
Actions

Authored by ashoat on Jun 4 2023, 10:03 AM.
Tags
None
Referenced Files
F3377183: D8087.id27466.diff
Wed, Nov 27, 4:17 AM
Unknown Object (File)
Sat, Nov 23, 9:10 AM
Unknown Object (File)
Tue, Nov 5, 10:08 PM
Unknown Object (File)
Mon, Nov 4, 10:50 AM
Unknown Object (File)
Fri, Nov 1, 9:30 AM
Unknown Object (File)
Fri, Nov 1, 9:30 AM
Unknown Object (File)
Fri, Nov 1, 9:30 AM
Unknown Object (File)
Fri, Nov 1, 9:29 AM
View All 94 Files
Subscribers
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMMf2e840061476: [native] Fix userInfo calculation in UserAvatar
Summary

The previous code was passing the wrong userInfo to useENSResolvedAvatar when the userInfo prop was specified. The new code keeps the decision in one place, with only one selector.

Depends on D8086

Test Plan

Make sure we're not randomly using the anonymous user emoji from EditUserAvatar rendered with a userInfo prop

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Jun 4 2023, 10:03 AM
Herald added a subscriber: tomek. · View Herald TranscriptJun 4 2023, 10:03 AM
ashoat added a child revision: D8088: [native] Move some types from avatar-selection.react.js to registration-types.js.Jun 4 2023, 10:06 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 4 2023, 10:13 AM
Harbormaster failed remote builds in B20008: Diff 27425!
ashoat edited parent revisions, added: D8085: [native] Change AvatarSelection button to say "Submit" instead of "Next"; removed: D8086: [native] Disable the EditUserAvatar component in AvatarSelection during registration.Jun 4 2023, 2:39 PM
ashoat updated this revision to Diff 27428.Jun 4 2023, 2:41 PM
ashoat added a parent revision: D8086: [native] Disable the EditUserAvatar component in AvatarSelection during registration.

Rebase

Harbormaster completed remote builds in B20011: Diff 27428.Jun 4 2023, 3:01 PM
ashoat requested review of this revision.Jun 4 2023, 3:01 PM
ashoat added a comment.Jun 6 2023, 5:28 AM

Ping on this review

atul accepted this revision.Jun 6 2023, 7:53 AM
This revision is now accepted and ready to land.Jun 6 2023, 7:53 AM
Closed by commit rCOMMf2e840061476: [native] Fix userInfo calculation in UserAvatar (authored by ashoat). · Explain WhyJun 6 2023, 8:18 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMf2e840061476: [native] Fix userInfo calculation in UserAvatar.

Revision Contents
Changeset List

PathSize
native/
avatars/
19 lines

Diff 27466

View Options

native/avatars/user-avatar.react.js

Loading...