Page MenuHomePhabricator
Differential D8186

[native] remove avatar feature flag logic
ClosedPublic
Actions

Authored by ginsu on Jun 12 2023, 1:18 PM.
Tags
None
Referenced Files
F3506741: D8186.diff
Fri, Dec 20, 6:06 PM
Unknown Object (File)
Sun, Dec 8, 1:59 AM
Unknown Object (File)
Sat, Dec 7, 1:24 PM
Unknown Object (File)
Sat, Dec 7, 1:08 PM
Unknown Object (File)
Wed, Dec 4, 2:39 AM
Unknown Object (File)
Wed, Dec 4, 2:39 AM
Unknown Object (File)
Wed, Dec 4, 2:39 AM
Unknown Object (File)
Sun, Nov 24, 10:47 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
Commits
rCOMM18d41045e9ea: [native] remove avatar feature flag logic
Summary

Now that avatars is in a stable spot, we can remove the return true feature flag function and the related logic to conditionally render avatars based on it

Test Plan

Made sure that as I was removing the feature flag code, the avatar rendering looked the same

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jun 12 2023, 1:18 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 12 2023, 1:18 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 12 2023, 1:20 PM
Harbormaster failed remote builds in B20193: Diff 27663!
ginsu updated this revision to Diff 27665.Jun 12 2023, 1:21 PM

rebase

ginsu added reviewers: atul, rohan.Jun 12 2023, 1:28 PM
Harbormaster completed remote builds in B20195: Diff 27665.Jun 12 2023, 1:40 PM
ginsu requested review of this revision.Jun 12 2023, 1:40 PM
atul accepted this revision.Jun 13 2023, 6:18 PM
This revision is now accepted and ready to land.Jun 13 2023, 6:18 PM
ginsu updated this revision to Diff 27756.Jun 14 2023, 10:03 AM

rebase before landing

Harbormaster completed remote builds in B20255: Diff 27756.Jun 14 2023, 10:21 AM
Closed by commit rCOMM18d41045e9ea: [native] remove avatar feature flag logic (authored by ginsu). · Explain WhyJun 14 2023, 10:24 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM18d41045e9ea: [native] remove avatar feature flag logic.

Revision Contents
Changeset List

Diff 27665

View Options

native/avatars/avatar.react.js

Loading...
View Options

native/chat/chat-thread-list-item.react.js

Loading...
View Options

native/chat/composed-message-width.js

Loading...
View Options

native/chat/composed-message.react.js

Loading...
View Options

native/chat/inline-engagement.react.js

Loading...
View Options

native/chat/message-header.react.js

Loading...
View Options

native/chat/message-list-header-title.react.js

Loading...
View Options

native/chat/message-reactions-modal.react.js

Loading...
View Options

native/chat/message-tooltip-button-avatar.react.js

Loading...
View Options

native/chat/settings/thread-settings-child-thread.react.js

Loading...
View Options

native/chat/settings/thread-settings-member.react.js

Loading...
View Options

native/chat/settings/thread-settings-parent.react.js

Loading...
View Options

native/chat/settings/thread-settings.react.js

Loading...
View Options

native/chat/typeahead-tooltip.react.js

Loading...
View Options

native/components/thread-list-thread.react.js

Loading...
View Options

native/navigation/community-drawer-item.react.js

Loading...
View Options

native/profile/profile-screen.react.js

Loading...
View Options

native/profile/relationship-list-item.react.js

Loading...
View Options

native/utils/avatar-utils.js

Loading...