Page MenuHomePhabricator
Differential D8106

Refactor CommIOSNotifications native and JavaScript code so that JavaScript registers to events using getConstants object instead of hardcoded strings
ClosedPublic
Actions

Authored by marcin on Jun 6 2023, 8:19 AM.
Tags
None
Referenced Files
F3673191: D8106.id.diff
Mon, Jan 6, 5:52 AM
F3673098: D8106.id27787.diff
Mon, Jan 6, 5:34 AM
F3673089: D8106.id27469.diff
Mon, Jan 6, 5:34 AM
F3673077: D8106.id27638.diff
Mon, Jan 6, 5:33 AM
F3673060: D8106.id27772.diff
Mon, Jan 6, 5:33 AM
F3673036: D8106.id27783.diff
Mon, Jan 6, 5:32 AM
F3673034: D8106.id27655.diff
Mon, Jan 6, 5:32 AM
Unknown Object (File)
Wed, Dec 25, 8:59 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
bartek
Commits
rCOMM91abea590ae5: Refactor CommIOSNotifications native and JavaScript code so that JavaScript…
Summary

This diferential refactors code so that JavaScript can access notifications related event names directly from getConstants property of CommIOSNotifications

Test Plan

Build the app. Test that notifications functionalities work

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Jun 6 2023, 8:19 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJun 6 2023, 8:19 AM
Harbormaster completed remote builds in B20041: Diff 27469.Jun 6 2023, 8:36 AM
marcin requested review of this revision.Jun 6 2023, 8:36 AM
marcin added a child revision: D8113: Refactor android notifications native and JavaScript code so that JS can register for events using native constants.Jun 6 2023, 8:53 AM
bartek accepted this revision.Jun 7 2023, 2:34 AM
This revision is now accepted and ready to land.Jun 7 2023, 2:34 AM
marcin updated this revision to Diff 27638.Jun 12 2023, 2:47 AM

Rebase before landing

Harbormaster failed remote builds in B20173: Diff 27638!Jun 12 2023, 2:49 AM
marcin updated this revision to Diff 27655.Jun 12 2023, 8:18 AM

Rebase before landing

Harbormaster completed remote builds in B20187: Diff 27655.Jun 12 2023, 8:48 AM
marcin updated this revision to Diff 27772.Jun 14 2023, 11:09 AM

Rebase before landing

Harbormaster completed remote builds in B20260: Diff 27772.Jun 14 2023, 11:27 AM
marcin updated this revision to Diff 27783.Jun 14 2023, 11:51 AM

Rebase before landing

Harbormaster completed remote builds in B20268: Diff 27783.Jun 14 2023, 12:08 PM
Closed by commit rCOMM91abea590ae5: Refactor CommIOSNotifications native and JavaScript code so that JavaScript… (authored by marcin). · Explain WhyJun 14 2023, 12:17 PM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM91abea590ae5: Refactor CommIOSNotifications native and JavaScript code so that JavaScript….

Revision Contents
Changeset List

PathSize
native/
ios/
Comm/
CommIOSNotifications/
43 lines
push/
17 lines
14 lines

Diff 27783

View Options

native/ios/Comm/CommIOSNotifications/CommIOSNotifications.mm

Loading...
View Options

native/push/ios.js

Loading...
View Options

native/push/push-handler.react.js

Loading...