Page MenuHomePhabricator

add search bar to emoji keyboard
ClosedPublic

Authored by ginsu on Jun 14 2023, 10:46 AM.
Tags
None
Referenced Files
F3575862: D8211.id27807.diff
Sat, Dec 28, 8:46 PM
F3575861: D8211.id27770.diff
Sat, Dec 28, 8:46 PM
F3575788: D8211.id.diff
Sat, Dec 28, 8:42 PM
F3575618: D8211.diff
Sat, Dec 28, 8:20 PM
Unknown Object (File)
Fri, Dec 20, 11:10 AM
Unknown Object (File)
Fri, Dec 20, 5:05 AM
Unknown Object (File)
Nov 23 2024, 1:03 PM
Unknown Object (File)
Nov 17 2024, 10:43 AM
Subscribers

Details

Summary

This diff adds the search bar to the emoji keyboard. To do this, I read through the docs and found this example here.

One thing to note is that searching for emoji sometimes is a little strange (take a look at the demo below), after App.js I did get on a call with the owners of this library, and did share with them that this is something this should be improved. They said they would work on it, so hoping this will be improved soon "for free". If we have other points of feedback too, I do have an open line of communication with their team and they are very friendly/open to feedback.

https://linear.app/comm/issue/ENG-3791/mobile-emoji-keyboard-search

Test Plan

Please view the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu edited the summary of this revision. (Show Details)
native/components/emoji-keyboard.react.js
21 ↗(On Diff #27770)

This disables the animation in the categories bar. I thought this animation was a bit strange/janky and preferred the experience without it so I disabled it.

This revision is now accepted and ready to land.Jun 15 2023, 3:28 AM
This revision was automatically updated to reflect the committed changes.