Page MenuHomePhabricator

Provided detailed error messages on olm functions failures in CryptoModule
ClosedPublic

Authored by marcin on Jun 6 2023, 9:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 29, 6:13 AM
Unknown Object (File)
Sun, Sep 29, 6:13 AM
Unknown Object (File)
Sun, Sep 29, 6:13 AM
Unknown Object (File)
Sun, Sep 29, 6:13 AM
Unknown Object (File)
Sun, Sep 29, 6:13 AM
Unknown Object (File)
Sun, Sep 29, 6:13 AM
Unknown Object (File)
Sun, Sep 29, 6:13 AM
Unknown Object (File)
Sun, Sep 29, 6:10 AM
Subscribers

Details

Summary

This differential refactors CryptoModule.cpp and Session.cpp so that each time olm function fails detailed and informative error message is provided.

Test Plan

It would be cumbersome to attempt to fail each olm function that is used in those files, however the fact that we already used this approach a couple of times:
https://linear.app/comm/issue/ENG-3982/recreate-keyserver-olm-accounts-on-dev-and-production-environments or here: https://linear.app/comm/issue/ENG-3844/unable-to-correctly-instantiate-olm-session-between-the-device-and-the should be enough to
consider it correct.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin requested review of this revision.Jun 6 2023, 9:36 AM
This revision is now accepted and ready to land.Jun 6 2023, 11:23 AM

(Restarted failing iOS build)