Page MenuHomePhabricator
Differential D8303

[native] Add a custom TabNavigator
ClosedPublic
Actions

Authored by • kuba on Jun 23 2023, 2:29 AM.
Tags
None
Referenced Files
F6238643: D8303.diff
Thu, Apr 24, 6:35 PM
Unknown Object (File)
Wed, Apr 23, 5:29 PM
Unknown Object (File)
Wed, Apr 23, 12:39 PM
Unknown Object (File)
Sun, Apr 20, 12:46 PM
Unknown Object (File)
Sun, Apr 20, 6:08 AM
Unknown Object (File)
Sat, Apr 19, 9:33 PM
Unknown Object (File)
Sat, Apr 19, 8:49 PM
Unknown Object (File)
Sat, Apr 19, 3:43 PM
View All Files
Subscribers
None

Details

Reviewers
michal
inka
ashoat
tomek
Commits
rCOMM38d235deab17: [native] Add a custom TabNavigator
Summary

I add a custom router and navigator for TabNavigator. In later diffs, the new router will be used to prevent the user from tab navigating in edit mode.

Test Plan

On iOS:

  • Open the app.
  • Navigate between tabs.

Diff Detail

Repository
rCOMM Comm
Branch
kuba/blocking-navigation
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• kuba created this revision.Jun 23 2023, 2:29 AM
• kuba added a parent revision: D8271: [native] Unblock scrolling when continuing editing.Jun 23 2023, 2:29 AM
• kuba retitled this revision from [native] Add custom TabNavigator to [native] Add a custom TabNavigator.
• kuba edited the summary of this revision. (Show Details)
• kuba added inline comments.Jun 23 2023, 2:31 AM
native/navigation/tab-router.js
22–27

Here is a draft of a custom getStateForAction. Going to be used in the next diff.

• kuba edited the test plan for this revision. (Show Details)Jun 23 2023, 2:38 AM
• kuba added a child revision: D8304: [native] Blocking navigation in edit mode in the TabRouter.Jun 23 2023, 2:43 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 23 2023, 2:52 AM
Harbormaster failed remote builds in B20451: Diff 28033!
• kuba requested review of this revision.Jun 23 2023, 5:17 AM
Harbormaster completed remote builds in B20451: Diff 28033.Jun 27 2023, 8:20 PM
ashoat accepted this revision.Jun 27 2023, 8:24 PM
This revision is now accepted and ready to land.Jun 27 2023, 8:24 PM
Closed by commit rCOMM38d235deab17: [native] Add a custom TabNavigator (authored by kosmydel <kukubaczek@gmail.com>, committed by kosmydel <104823336+kosmydel@users.noreply.github.com>). · Explain WhyJul 13 2023, 1:57 AM
This revision was automatically updated to reflect the committed changes.
kosmydel <104823336+kosmydel@users.noreply.github.com> added a commit: rCOMM38d235deab17: [native] Add a custom TabNavigator.

Revision Contents
Changeset List

PathSize
native/
navigation/
78 lines
32 lines

Diff 28033

View Options

native/navigation/tab-navigator.react.js

// @flow // @flow
import Alert from 'react-native/Libraries/Alert/Alert.js'; import Alert from 'react-native/Libraries/Alert/Alert.js';
function exitEditAlert(onDiscard: () => void): void { function exitEditAlert(onDiscard: () => void, onPress: ?() => void): void {
Alert.alert( Alert.alert(
'Discard changes?', 'Discard changes?',
'You have unsaved changes which will be discarded if you navigate away.', 'You have unsaved changes which will be discarded if you navigate away.',
[ [
{ {
text: 'Continue editing', text: 'Continue editing',
style: 'cancel', style: 'cancel',
onPress: onPress,
tomekUnsubmitted
Not Done
Inline Actions
import Alert from 'react-native/Libraries/Alert/Alert.js';
- function exitEditAlert(onDiscard: () => void, onPress: ?() => void): void {
+ function exitEditAlert(onDiscard: () => void, onContinueEditing: ?() => void): void {
Alert.alert(
'Discard changes?',
'You have unsaved changes which will be discarded if you navigate away.',
[
{
text: 'Continue editing',
style: 'cancel',
- onPress: onPress,
+ onPress: onContinueEditing,
},
{
text: 'Discard edit',

Maybe we should be more explicit in naming these

tomek: Maybe we should be more explicit in naming these
}, },
{ {
text: 'Discard edit', text: 'Discard edit',
style: 'destructive', style: 'destructive',
onPress: () => { onPress: onDiscard,
onDiscard();
},
}, },
], ],
); );
} }
export { exitEditAlert }; export { exitEditAlert };
View Options

native/navigation/tab-router.js

// @flow // @flow
import Alert from 'react-native/Libraries/Alert/Alert.js'; import Alert from 'react-native/Libraries/Alert/Alert.js';
function exitEditAlert(onDiscard: () => void): void { function exitEditAlert(onDiscard: () => void, onPress: ?() => void): void {
Alert.alert( Alert.alert(
'Discard changes?', 'Discard changes?',
'You have unsaved changes which will be discarded if you navigate away.', 'You have unsaved changes which will be discarded if you navigate away.',
[ [
{ {
text: 'Continue editing', text: 'Continue editing',
style: 'cancel', style: 'cancel',
onPress: onPress,
tomekUnsubmitted
Not Done
Inline Actions
import Alert from 'react-native/Libraries/Alert/Alert.js';
- function exitEditAlert(onDiscard: () => void, onPress: ?() => void): void {
+ function exitEditAlert(onDiscard: () => void, onContinueEditing: ?() => void): void {
Alert.alert(
'Discard changes?',
'You have unsaved changes which will be discarded if you navigate away.',
[
{
text: 'Continue editing',
style: 'cancel',
- onPress: onPress,
+ onPress: onContinueEditing,
},
{
text: 'Discard edit',

Maybe we should be more explicit in naming these

tomek: Maybe we should be more explicit in naming these
}, },
{ {
text: 'Discard edit', text: 'Discard edit',
style: 'destructive', style: 'destructive',
onPress: () => { onPress: onDiscard,
onDiscard();
},
}, },
], ],
); );
} }
export { exitEditAlert }; export { exitEditAlert };