Page MenuHomePhabricator

[web] Use local holder for blob deletion
ClosedPublic

Authored by bartek on Jun 26 2023, 9:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 23 2024, 1:15 PM
Unknown Object (File)
Nov 23 2024, 1:15 PM
Unknown Object (File)
Nov 23 2024, 1:14 PM
Unknown Object (File)
Nov 23 2024, 1:14 PM
Unknown Object (File)
Nov 17 2024, 8:21 AM
Unknown Object (File)
Nov 10 2024, 12:33 PM
Unknown Object (File)
Nov 9 2024, 4:19 AM
Unknown Object (File)
Nov 8 2024, 8:03 AM
Subscribers

Details

Summary

Replaces D8257 - on web, a newly-created blob holder needs to be kept to be able to delete the blob, when a user cancels sending a media while it is already uploaded

Depends on D8256

Test Plan

Enabled blob service uploads, selected a photo to send. Ensured the blob was uploaded successfully. Then clicked the cross button to unselect the photo. Ensured the blob was deleted

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek edited the test plan for this revision. (Show Details)
bartek published this revision for review.Jun 26 2023, 11:11 PM
bartek added inline comments.
web/input/input-state-container.react.js
1080

This void was incorrect previously. It should initially be UploadMultimediaResult.

This revision is now accepted and ready to land.Jun 28 2023, 11:09 AM
bartek edited the summary of this revision. (Show Details)

Rebase

This revision was automatically updated to reflect the committed changes.