Page MenuHomePhabricator
Differential D8206

[blob-service][HTTP] Get blobs by blob_hash
ClosedPublic
Actions

Authored by bartek on Jun 14 2023, 4:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 5:46 PM
Unknown Object (File)
Tue, Mar 4, 10:28 AM
Unknown Object (File)
Tue, Mar 4, 10:28 AM
Unknown Object (File)
Tue, Mar 4, 10:28 AM
Unknown Object (File)
Tue, Mar 4, 10:28 AM
Unknown Object (File)
Tue, Mar 4, 10:23 AM
Unknown Object (File)
Sat, Mar 1, 3:14 AM
Unknown Object (File)
Feb 18 2025, 9:24 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
• jon
varun
michal
Commits
rCOMMf0790c1553fa: [blob-service][HTTP] Get blobs by blob_hash
Summary

Resolves ENG-3967.
Changed Blob Service HTTP get endpoint to accept blob_hash instead of holder.

Test Plan

Uploaded an image to blob service with blob_hash = test_hash1, then I wasa able to download it by entering http://BLOB_SERVICE/blob/test_hash1 in the browser.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
blob/
src/
http/
16 lines
handlers/
15 lines

Diff 28240

View Options

services/blob/src/http/context.rs

FROM commapp/services-base:1.3.2 as builder FROM rust:1.70-bullseye as builder
ENV PATH=/root/.cargo/bin:$PATH RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \
# Install Curl
RUN apt-get update \
&& DEBIAN_FRONTEND=noninteractive apt-get install -y curl \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
# Install Rust WORKDIR /home/root/app/feature-flags
RUN curl https://sh.rustup.rs -sSf | sh -s -- -y
RUN mkdir -p /home/comm/app/feature-flags
WORKDIR /home/comm/app/feature-flags
RUN cargo init --bin
# Cache build dependencies in a new layer ENV CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
COPY services/blob/Cargo.toml services/blob/Cargo.lock ./
COPY services/comm-services-lib ../comm-services-lib
RUN cargo build --release
# Copy actual application sources # Copy actual application sources
COPY services/feature-flags . COPY services/comm-services-lib ../comm-services-lib
COPY services/feature-flags ./
# Remove the previously-built binary so that only the application itself is RUN cargo install --locked --path .
# rebuilt
RUN rm -f ./target/release/deps/feature-flags*
RUN cargo build --release
# Runner stage # Runner stage
FROM commapp/services-base:1.3.2 as runner FROM debian:bullseye-slim as runner
# Create a new user comm and use it to run subsequent commands # Update dependencies, install ca-certificates which are required for TLS
RUN useradd -m comm RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
USER comm ca-certificates \
&& rm -rf /var/lib/apt/lists/*
# Only copy built binary from builder stage # Only copy built binary from builder stage
COPY --from=builder /usr/local/cargo/bin/feature-flags /usr/local/bin/feature-flags
WORKDIR /home/comm/app/feature-flags WORKDIR /home/comm/app/feature-flags
COPY --from=builder /home/comm/app/feature-flags/target/release/feature-flags .
ARG COMM_SERVICES_SANDBOX # Create a new user comm and use it to run subsequent commands
ENV COMM_SERVICES_SANDBOX=${COMM_SERVICES_SANDBOX} RUN useradd -m comm
USER comm
ENV RUST_LOG=info
CMD ./feature-flags CMD ["feature-flags"]
View Options

services/blob/src/http/handlers/blob.rs

FROM commapp/services-base:1.3.2 as builder FROM rust:1.70-bullseye as builder
ENV PATH=/root/.cargo/bin:$PATH RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \
# Install Curl
RUN apt-get update \
&& DEBIAN_FRONTEND=noninteractive apt-get install -y curl \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
# Install Rust WORKDIR /home/root/app/feature-flags
RUN curl https://sh.rustup.rs -sSf | sh -s -- -y
RUN mkdir -p /home/comm/app/feature-flags
WORKDIR /home/comm/app/feature-flags
RUN cargo init --bin
# Cache build dependencies in a new layer ENV CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
COPY services/blob/Cargo.toml services/blob/Cargo.lock ./
COPY services/comm-services-lib ../comm-services-lib
RUN cargo build --release
# Copy actual application sources # Copy actual application sources
COPY services/feature-flags . COPY services/comm-services-lib ../comm-services-lib
COPY services/feature-flags ./
# Remove the previously-built binary so that only the application itself is RUN cargo install --locked --path .
# rebuilt
RUN rm -f ./target/release/deps/feature-flags*
RUN cargo build --release
# Runner stage # Runner stage
FROM commapp/services-base:1.3.2 as runner FROM debian:bullseye-slim as runner
# Create a new user comm and use it to run subsequent commands # Update dependencies, install ca-certificates which are required for TLS
RUN useradd -m comm RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
USER comm ca-certificates \
&& rm -rf /var/lib/apt/lists/*
# Only copy built binary from builder stage # Only copy built binary from builder stage
COPY --from=builder /usr/local/cargo/bin/feature-flags /usr/local/bin/feature-flags
WORKDIR /home/comm/app/feature-flags WORKDIR /home/comm/app/feature-flags
COPY --from=builder /home/comm/app/feature-flags/target/release/feature-flags .
ARG COMM_SERVICES_SANDBOX # Create a new user comm and use it to run subsequent commands
ENV COMM_SERVICES_SANDBOX=${COMM_SERVICES_SANDBOX} RUN useradd -m comm
USER comm
ENV RUST_LOG=info
CMD ./feature-flags CMD ["feature-flags"]