Page MenuHomePhabricator
Differential D8304

[native] Blocking navigation in edit mode in the TabRouter
ClosedPublic
Actions

Authored by • kuba on Jun 23 2023, 2:43 AM.
Tags
None
Referenced Files
F3404760: D8304.diff
Tue, Dec 3, 1:04 PM
Unknown Object (File)
Mon, Nov 25, 2:49 PM
Unknown Object (File)
Sat, Nov 23, 4:16 PM
Unknown Object (File)
Sat, Nov 23, 2:04 PM
Unknown Object (File)
Sat, Nov 23, 2:04 PM
Unknown Object (File)
Sat, Nov 23, 2:04 PM
Unknown Object (File)
Wed, Nov 13, 10:42 PM
Unknown Object (File)
Tue, Nov 12, 11:59 PM
View All Files
Subscribers
None

Details

Reviewers
michal
inka
ashoat
tomek
Commits
rCOMMe47c6986057e: [native] Blocking navigation in edit mode in the TabRouter
Summary

When we are in edit mode and the user made changes, we prevent him in this diff from changing tabs.

Test Plan

On iOS:

  • Navigate between threads - check if everything works.
  • Navigate between tabs - check if everything works.
  • Enter edit mode and make changes to the message,
  • Change tab - should confirm with alert.
  • Do the same in the sidebar (enter edit mode and check if the alert displays).

Diff Detail

Repository
rCOMM Comm
Branch
kuba/blocking-navigation
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• kuba created this revision.Jun 23 2023, 2:43 AM
• kuba added a parent revision: D8303: [native] Add a custom TabNavigator.Jun 23 2023, 2:43 AM
• kuba edited the summary of this revision. (Show Details)
• kuba added inline comments.
native/navigation/nav-selectors.js
340–347 ↗(On Diff #28035)

I split it into two functions to reuse it in the new router.

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 23 2023, 3:04 AM
Harbormaster failed remote builds in B20453: Diff 28035!
• kuba requested review of this revision.Jun 23 2023, 5:17 AM
• kuba updated this revision to Diff 28137.Jun 27 2023, 12:25 AM

Change to function syntax

Harbormaster completed remote builds in B20523: Diff 28137.Jun 27 2023, 12:41 AM
• kuba updated this revision to Diff 28141.Jun 27 2023, 1:38 AM

Rebase & fix calling dispatch from reducer

Harbormaster completed remote builds in B20527: Diff 28141.Jun 27 2023, 1:54 AM
ashoat accepted this revision.Jun 27 2023, 8:05 PM
This revision is now accepted and ready to land.Jun 27 2023, 8:05 PM
Closed by commit rCOMMe47c6986057e: [native] Blocking navigation in edit mode in the TabRouter (authored by kosmydel <kukubaczek@gmail.com>, committed by kosmydel <104823336+kosmydel@users.noreply.github.com>). · Explain WhyJul 13 2023, 1:57 AM
This revision was automatically updated to reflect the committed changes.
kosmydel <104823336+kosmydel@users.noreply.github.com> added a commit: rCOMMe47c6986057e: [native] Blocking navigation in edit mode in the TabRouter.

Revision Contents
Changeset List

PathSize
native/
navigation/
11 lines
9 lines
11 lines

Diff 28137

View Options

native/navigation/nav-selectors.js

Loading...
View Options

native/navigation/overlay-router.js

Loading...
View Options

native/navigation/tab-router.js

Loading...