Details
Details
- Reviewers
atul ashoat - Commits
- rCOMM2bb6d801c1fd: [web] Use colors from themes.css in dropdown
Confirmed that both enabled and disabled dropdowns still look the same
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- change_roles-quickfix
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
web/components/dropdown.react.js | ||
---|---|---|
39 ↗ | (On Diff #28187) | I guess we do !!disabled above in the other calls to classNames, so it's probably best to maintain consistency. |
web/theme.css | ||
---|---|---|
235 ↗ | (On Diff #28187) | Oh yeah thanks for catching that |
How is application going to function if this error occurs? In most places we the runtime error to kill the app if database operation fails since application is not going to work correctly. I just want to know whether it is also the case here.